Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docker): upgrade base image to ubuntu 24.04 #99

Merged

Conversation

wirespecter
Copy link
Contributor

Closes reanahub/reana#808
Old PR: #98

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.66%. Comparing base (2dd079e) to head (6aae67f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #99      +/-   ##
=========================================
- Coverage    3.78%   3.66%   -0.12%     
=========================================
  Files           6       6              
  Lines         185     191       +6     
=========================================
  Hits            7       7              
- Misses        178     184       +6     

see 2 files with indirect coverage changes

@mdonadoni
Copy link
Member

mdonadoni commented Jul 25, 2024

It seems like we have some issues after the upgrade.

In particular, this workflow fails:

Snakefile

def get_all_inputs(wildcards):
    import os
    files = os.listdir("inputs")
    full_files = [f"inputs/{file}" for file in files]
    return full_files

rule all:
    input:
        "results/merged.txt"

rule merge:
    input:
        get_all_inputs
    output:
        "results/merged.txt"
    container:
        "docker://docker.io/library/ubuntu:20.04"
    shell:
        "mkdir results && echo done > {output}"

reana.yaml

inputs:
  directories:
    - inputs
  files:
    - Snakefile
workflow:
  type: snakemake
  file: Snakefile

File structure (input files are empty)

$ tree
.
├── inputs
│   ├── a.txt
│   ├── b.txt
│   └── c.txt
├── reana.yaml
└── Snakefile

2 directories, 5 files

Error reported by REANA

2024-07-25 15:32:02,164 | snakemake.logging | MainThread | CRITICAL | File path ' inputs/ a.txt ' ends with whitespace. This is likely unintended. It can also lead to inconsistent results of the file-matching approach used by Snakemake.
2024-07-25 15:32:02,168 | snakemake.logging | MainThread | ERROR | MissingInputException in rule merge in file /var/reana/users/00000000-0000-0000-0000-000000000000/workflows/fbd5cc04-f1be-4078-b1db-4b55809d3b0b/Snakefile, line 11:
Missing input files for rule merge:
    output: results/merged.txt
    affected files:
         inputs/ a.txt 
         inputs/ c.txt 
         inputs/ b.txt 

For some reason, the files have whitespaces in their filename, we can have a look together

Edit: see also snakemake/snakemake#2480

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
wirespecter added a commit to wirespecter/reana-workflow-engine-snakemake that referenced this pull request Jul 26, 2024
@wirespecter wirespecter force-pushed the ubuntu-24.04-docker-image-upgrade2 branch from f8413d1 to 0487b81 Compare July 26, 2024 11:39
wirespecter added a commit to wirespecter/reana-workflow-engine-snakemake that referenced this pull request Aug 1, 2024
@wirespecter wirespecter force-pushed the ubuntu-24.04-docker-image-upgrade2 branch from 0487b81 to 3f034f0 Compare August 1, 2024 12:21
@wirespecter wirespecter changed the title build(docker): upgraded docker image to ubuntu 24.04 build(docker): upgrade base image to ubuntu 24.04 Aug 1, 2024
wirespecter added a commit to wirespecter/reana-workflow-engine-snakemake that referenced this pull request Aug 2, 2024
wirespecter added a commit to wirespecter/reana-workflow-engine-snakemake that referenced this pull request Aug 2, 2024
@wirespecter wirespecter force-pushed the ubuntu-24.04-docker-image-upgrade2 branch from 8cca02c to b265591 Compare August 2, 2024 07:34
Dockerfile Show resolved Hide resolved
wirespecter added a commit to wirespecter/reana-workflow-engine-snakemake that referenced this pull request Aug 6, 2024
@wirespecter wirespecter force-pushed the ubuntu-24.04-docker-image-upgrade2 branch from b265591 to 7811bd0 Compare August 6, 2024 13:35
wirespecter added a commit to wirespecter/reana-workflow-engine-snakemake that referenced this pull request Aug 6, 2024
@wirespecter wirespecter force-pushed the ubuntu-24.04-docker-image-upgrade2 branch from 7811bd0 to 4fec792 Compare August 6, 2024 13:40
wirespecter added a commit to wirespecter/reana-workflow-engine-snakemake that referenced this pull request Aug 6, 2024
@wirespecter wirespecter force-pushed the ubuntu-24.04-docker-image-upgrade2 branch from 4fec792 to d85ff2e Compare August 6, 2024 13:42
@wirespecter wirespecter force-pushed the ubuntu-24.04-docker-image-upgrade2 branch from d85ff2e to 6aae67f Compare August 7, 2024 11:45
@tiborsimko tiborsimko merged commit 6aae67f into reanahub:master Aug 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: upgrade all base docker images to ubuntu 24.04
3 participants