Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: add cronjob to autoclose interactive sessions #693

Merged
merged 2 commits into from
Feb 20, 2023

Conversation

audrium
Copy link
Member

@audrium audrium commented Feb 9, 2023

closes reanahub/reana-workflow-controller#498

To test update values.yaml with:

interactive_sessions:
  cronjob_schedule: "*/2 * * * *"  # every 2 minutes
  maximum_duration: 0

It will try to auto-close all the sessions every two minutes

@codecov-commenter
Copy link

Codecov Report

Merging #693 (5cc8fd4) into master (868775c) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #693   +/-   ##
=======================================
  Coverage   18.84%   18.84%           
=======================================
  Files          26       26           
  Lines        2144     2144           
=======================================
  Hits          404      404           
  Misses       1740     1740           
Impacted Files Coverage Δ
reana/reana_dev/run.py 26.72% <ø> (ø)

@audrium
Copy link
Member Author

audrium commented Feb 10, 2023

One possible addition could be to pass maximum_duration value set by administrators down to reana-ui and to enrich the current notification with a message indicating that the session will be closed after a specified number of days. I've quickly checked that it's not feasible to show the notification in the actual jupyter notebook itself, but we could at least inform users in REANA.

Edit: implemented in reanahub/reana-ui#312

@audrium audrium force-pushed the interactive-session-autoclosure branch from 5cc8fd4 to c6d228e Compare February 13, 2023 12:43
helm/reana/values.yaml Outdated Show resolved Hide resolved
helm/reana/templates/cronjobs.yaml Outdated Show resolved Hide resolved
@audrium audrium merged commit de40ea4 into reanahub:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configurable auto-closure of interactive sessions after days of inactivity
3 participants