dev: delete extra file when running git-submodule --update #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #764 +/- ##
=======================================
Coverage 18.61% 18.61%
=======================================
Files 26 26
Lines 2326 2326
=======================================
Hits 433 433
Misses 1893 1893
|
tiborsimko
reviewed
Dec 6, 2023
CHANGES.rst
Outdated
| -------------------------- | ||
|
|
||
| - Developers: | ||
| - Changes `git-submodule --update` command to delete from the cluster `moduels` folder the files that are not present in the shared modules directories. |
There was a problem hiding this comment.
- Note the typo (
modules). - Suggestion: end the phrase with "... that are not present anymore in the shared modules source directories."
giuseppe-steduto
force-pushed
the
git-submodule-delete-when-updating
branch
from
8cedf29
to
8721571
Compare
mdonadoni
reviewed
Dec 19, 2023
giuseppe-steduto
force-pushed
the
git-submodule-delete-when-updating
branch
from
8721571
to
97b2d07
Compare
mdonadoni
reviewed
Jan 17, 2024
CHANGES.rst
Outdated
Comment on lines
4
to
9
| Version 0.9.3 (UNRELEASED) | ||
| -------------------------- | ||
|
|
||
| - Developers: | ||
| - Changes `git-submodule --update` command to delete from the cluster `modules` folder the files that are not present anymore in the shared modules directories. | ||
|
|
There was a problem hiding this comment.
No need to update the CHANGELOG now that we have moved to release-please
giuseppe-steduto
force-pushed
the
git-submodule-delete-when-updating
branch
from
97b2d07
to
70e1bb1
Compare
giuseppe-steduto
added a commit
to giuseppe-steduto/reana
that referenced
this pull request
Jan 17, 2024
…nahub#764) Change the `git-submodule --update` command to delete from the `modules` folder of the cluster components the files that are not present in the original directories, reflecting a more accurate status of the shared modules. Closes reanahub#761.
giuseppe-steduto
force-pushed
the
git-submodule-delete-when-updating
branch
from
70e1bb1
to
267c4ae
Compare
…hub#764) Change the `git-submodule --update` command to delete from the `modules` folder of the cluster components the files that are not present in the original directories, reflecting a more accurate status of the shared modules. Closes reanahub#761.
giuseppe-steduto
force-pushed
the
git-submodule-delete-when-updating
branch
from
267c4ae
to
e5680ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the
git-submodule --updatecommand to delete from themodulesfolder of the cluster components the files that are not present in the
original directories, reflecting a more accurate status of the shared
modules.
Closes #761.