Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(commitlint): check for the presence of concrete PR number #86

Merged
merged 2 commits into from
Jan 26, 2024
Merged

ci(commitlint): check for the presence of concrete PR number #86

merged 2 commits into from
Jan 26, 2024

Conversation

tiborsimko
Copy link
Member

  • ci(commitlint): check for the presence of concrete PR number

    Enrich commitlint checker in order to check the precise PR number in the
    commit log headline.

  • ci(shellcheck): fix exit code propagation

    Return properly the exit code status of shellcheck command when looping
    through shell script files.

@tiborsimko
ci(shellcheck): fix exit code propagation (reanahub#86)
18aa60b 
Return properly the exit code status of shellcheck command when looping
through shell script files.
@tiborsimko
ci(commitlint): check for the presence of concrete PR number (reanahu…
3209045 
…b#86)

Enrich commitlint checker in order to check the precise PR number in the
commit log headline.
mdonadoni
mdonadoni approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@mdonadoni mdonadoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, but for some reason one of the URLs in the docs is reported as broke, even though I can access it from my computer

@tiborsimko
Copy link
Member Author

Works well, but for some reason one of the URLs in the docs is reported as broke, even though I can access it from my computer

Yes, it must have been a temporarily accessibility within the given time window, I just made the PR green by rerunning the failed CI job.

@tiborsimko tiborsimko merged commit 3209045 into reanahub:master Jan 26, 2024
5 checks passed
@tiborsimko tiborsimko deleted the ci-commitlint-shellcheck branch January 26, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdonadoni mdonadoni mdonadoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiborsimko @mdonadoni