fix: dict patch

reata · Apr 7, 2024 · 54114c9 · 54114c9
1 parent 5ba5cf7
commit 54114c9
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 12 deletions.
diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml
@@ -29,9 +29,6 @@ jobs:
         node-version: '16'
     - name: Install
       run: pip install tox codecov
-    - name: Echo home
-      run:
-        python -c "import os; print(os.path.expanduser('~')); print(os.environ.get('USERPROFILE')); print(os.environ.get('HOMEPATH')); print(os.environ.get('HOMEDRIVE')); print(os.environ.get('HOME'))"
     - name: Script
       run: tox -e py
     - name: After Success

diff --git a/tests/core/test_config.py b/tests/core/test_config.py
@@ -11,8 +11,8 @@
 from sqllineage.runner import LineageRunner
 
 
-@patch(
-    "os.environ",
+@patch.dict(
+    os.environ,
     {
         "SQLLINEAGE_DIRECTORY": os.path.join(os.path.dirname(__file__), "data"),
         "SQLLINEAGE_DEFAULT_SCHEMA": "<default>",

diff --git a/tests/core/test_exception.py b/tests/core/test_exception.py
@@ -1,3 +1,4 @@
+import os
 from unittest.mock import patch
 
 import pytest
@@ -56,7 +57,7 @@ def test_syntax_warning_no_semicolon_in_tsql():
         )._eval()
 
 
-@patch("os.environ", {"SQLLINEAGE_TSQL_NO_SEMICOLON": "TRUE"})
+@patch.dict(os.environ, {"SQLLINEAGE_TSQL_NO_SEMICOLON": "TRUE"})
 def test_user_warning_enable_tsql_no_semicolon_with_other_dialect():
     with pytest.warns(UserWarning):
         LineageRunner(

diff --git a/tests/sql/column/test_column_select_lateral_alias_ref.py b/tests/sql/column/test_column_select_lateral_alias_ref.py
@@ -1,3 +1,4 @@
+import os
 from unittest.mock import patch
 
 import pytest
@@ -14,7 +15,7 @@
 
 
 @pytest.mark.parametrize("provider", providers)
-@patch("os.environ", {"SQLLINEAGE_LATERAL_COLUMN_ALIAS_REFERENCE": "1"})
+@patch.dict(os.environ, {"SQLLINEAGE_LATERAL_COLUMN_ALIAS_REFERENCE": "1"})
 def test_column_top_level_enable_lateral_ref(
     provider: MetaDataProvider,
 ):
@@ -106,7 +107,7 @@ def test_column_top_level_enable_lateral_ref(
 
 
 @pytest.mark.parametrize("provider", providers)
-@patch("os.environ", {"SQLLINEAGE_LATERAL_COLUMN_ALIAS_REFERENCE": "1"})
+@patch.dict(os.environ, {"SQLLINEAGE_LATERAL_COLUMN_ALIAS_REFERENCE": "1"})
 def test_column_top_level_enable_lateral_ref_with_metadata_from_table(
     provider: MetaDataProvider,
 ):
@@ -148,7 +149,7 @@ def test_column_top_level_enable_lateral_ref_with_metadata_from_table(
 
 
 @pytest.mark.parametrize("provider", providers)
-@patch("os.environ", {"SQLLINEAGE_LATERAL_COLUMN_ALIAS_REFERENCE": "1"})
+@patch.dict(os.environ, {"SQLLINEAGE_LATERAL_COLUMN_ALIAS_REFERENCE": "1"})
 def test_column_top_level_enable_lateral_ref_with_metadata_from_subquery(
     provider: MetaDataProvider,
 ):
@@ -195,7 +196,7 @@ def test_column_top_level_enable_lateral_ref_with_metadata_from_subquery(
 
 
 @pytest.mark.parametrize("provider", providers)
-@patch("os.environ", {"SQLLINEAGE_LATERAL_COLUMN_ALIAS_REFERENCE": "1"})
+@patch.dict(os.environ, {"SQLLINEAGE_LATERAL_COLUMN_ALIAS_REFERENCE": "1"})
 def test_column_top_level_enable_lateral_ref_with_metadata_from_nested_subquery(
     provider: MetaDataProvider,
 ):
@@ -247,7 +248,7 @@ def test_column_top_level_enable_lateral_ref_with_metadata_from_nested_subquery(
 
 
 @pytest.mark.parametrize("provider", providers)
-@patch("os.environ", {"SQLLINEAGE_LATERAL_COLUMN_ALIAS_REFERENCE": "1"})
+@patch.dict(os.environ, {"SQLLINEAGE_LATERAL_COLUMN_ALIAS_REFERENCE": "1"})
 def test_column_enable_lateral_ref_within_subquery(
     provider: MetaDataProvider,
 ):

diff --git a/tests/sql/table/multiple_statements/test_tsql_no_semicolon.py b/tests/sql/table/multiple_statements/test_tsql_no_semicolon.py
@@ -1,11 +1,12 @@
+import os
 from unittest.mock import patch
 
 import pytest
 
 from ....helpers import assert_table_lineage_equal
 
 
-@patch("os.environ", {"SQLLINEAGE_TSQL_NO_SEMICOLON": "TRUE"})
+@patch.dict(os.environ, {"SQLLINEAGE_TSQL_NO_SEMICOLON": "TRUE"})
 @pytest.mark.parametrize("dialect", ["tsql"])
 def test_tsql_multi_statement_no_semicolon(dialect: str):
     """