Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: respect sqlfluff configuration file #582

Merged
merged 3 commits into from
Apr 7, 2024
Merged

feat: respect sqlfluff configuration file #582

merged 3 commits into from
Apr 7, 2024

Conversation

reata
Copy link
Owner

@reata reata commented Feb 23, 2024

Closes #548

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.50%. Comparing base (3574f2d) to head (950b510).
Report is 3 commits behind head on master.

❗ Current head 950b510 differs from pull request most recent head 54114c9. Consider uploading reports for the commit 54114c9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #582   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files          41       41           
  Lines        2219     2219           
=======================================
  Hits         2208     2208           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reata
Copy link
Owner Author

reata commented Feb 24, 2024

Two windows-related issues to be solved:

  1. working path in C driver, repo path in D driver. sqlfluff throws an exception when no common path can be extracted. This is fixed in latest sqlfluff main branch via b7f6933ac52bea7f12189a54458eb0229788d107.
  2. os.path.expanduser("~") in windows-latest image does not expand and instead returns "~".

@reata reata merged commit 3170768 into master Apr 7, 2024
30 checks passed
delphisharp pushed a commit to delphisharp/sqllineage that referenced this pull request Apr 15, 2024
* feat: respect sqlfluff configuration file

* fix: dict patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable support of sqlfluff context
1 participant