Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dunification #335

Merged
merged 26 commits into from
Nov 4, 2023
Merged

Dunification #335

merged 26 commits into from
Nov 4, 2023

Conversation

trite
Copy link

@trite trite commented Apr 13, 2023

No description provided.

@johnhaley81
Copy link
Contributor

Hey all! I added a few commits onto this branch that yields a working version of relude in melange. We can more formalize this when the next version of bisect_ppx is published and then I can PR my changes in https://github.com/johnhaley81/bastet/tree/melange to bastet and then we can update this PR as well. SO CLOSE!

@trite
Copy link
Author

trite commented Nov 4, 2023

@andywhite37 @mlms13 - There are some changes here that get things working with Melange 2 (ty @jakubrpawlowski ). I'm pretty sure the CI steps will still fail due to whatever was wrong with the bisect-ppx coveralls report.

Any thoughts on removing the coveralls step outright? Might be worth running the workflow steps once and seeing what happens, but I don't have perms to run it.

@trite
Copy link
Author

trite commented Nov 4, 2023

Bisect_ppx and coveralls have been removed in order to get things going, should bring back some coverage reporting later on.

@mlms13 mlms13 merged commit 5a76fd6 into reazen:v2 Nov 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants