This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
Support for TGW Attachment Peering resources #996
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This PR is for adding support to remove TGW Attachment Peering resources, as for now only VPC attachments are supported.
I thought about creating a couple of functions, one for "VPC" resources, and another for "Peering", but I didn't wanted to touch too many code unless it is strictly required.
If you want me to perform more changes please let me know.
Thanks!
Evidence
Before this change, any Nuke execution failed when trying to remove a TGW Attachment "peering" resource using the VPC removal API:
After this change, it works as expected, and the resources are being deleted 🎉