-
Notifications
You must be signed in to change notification settings - Fork 424
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #544 from rechsteiner/fix-color-interpolation-crash
Fix crash when using UIColor(patternImage:)
- Loading branch information
Showing
6 changed files
with
46 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
12 changes: 12 additions & 0 deletions
12
ParchmentTests/Resources.xcassets/Green.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "Green.png", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import CoreGraphics | ||
| import XCTest | ||
| @testable import Parchment | ||
|
|
||
| final class UIColorInterpolationTests: XCTestCase { | ||
| // Colors initialized with UIColor(patternImage:) have only 1 | ||
| // color component. This test ensures we don't crash. | ||
| func testImageFromPatternImageDefaultToBlack() { | ||
| let from = UIColor.red | ||
| let bundle = Bundle(for: Self.self) | ||
| let image = UIImage(named: "Green", in: bundle, compatibleWith: nil)! | ||
| let to = UIColor(patternImage: image) | ||
| let result = UIColor.interpolate(from: from, to: to, with: 1) | ||
|
|
||
| XCTAssertEqual(result, UIColor(red: 0, green: 0, blue: 0, alpha: 1)) | ||
| } | ||
| } |