Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistency of field names in data extension settings #165

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Fix inconsistency of field names in data extension settings #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions draft/examples/data-extension-metadata/valid/example-full.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
"proposeProperties": true,
"propertySettings": [
{
"name": "limit",
"label": "Limit",
"id": "limit",
"name": "Limit",
"type": "number",
"default": 0,
"helpText": "Maximum number of values to return per row (0 for no limit)"
},
{
"name": "content",
"label": "Content",
"id": "content",
"name": "Content",
"type": "select",
"default": "literal",
"helpText": "Content type: ID or literal",
Expand Down
8 changes: 4 additions & 4 deletions draft/examples/manifest/invalid/slub-invalid-property-setting.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,15 @@
{
"default": 10,
"helpText": "Maximum number of values to return per row (maximum: 1000)",
"label": "Limit",
"name": "limit",
"name": "Limit",
"id": "limit",
"type": "number"
},
{
"default": "geo,organizations,slub-resources,persons,events,topics,works, ",
"helpText": "Which Entity-Type to use, allwed values: http://schema.org/CreativeWork, http://schema.org/Work, http://schema.org/Event, http://schema.org/Place, http://schema.org/Person, http://schema.org/Book, http://schema.org/Organization, http://schema.org/Topic, http://schema.org/CreativeWorkSeries",
"label": "Typ",
"name": "type",
"name": "Typ",
"id": "type",
"type": "string"
}
],
Expand Down
8 changes: 4 additions & 4 deletions draft/examples/manifest/valid/lobid-gnd.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,15 @@
"extend": {
"propertySettings": [
{
"name": "limit",
"label": "Limit",
"id": "limit",
"name": "Limit",
"type": "number",
"default": 0,
"helpText": "Maximum number of values to return per row (0 for no limit)"
},
{
"name": "content",
"label": "Content",
"id": "content",
"name": "Content",
"type": "select",
"default": "literal",
"helpText": "Content type: ID or literal",
Expand Down
16 changes: 8 additions & 8 deletions draft/examples/manifest/valid/wikidata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@
"extend": {
"propertySettings": [
{
"name": "limit",
"label": "Limit",
"id": "limit",
"name": "Limit",
"helpText": "Maximum number of values to return per row (0 for no limit)",
"type": "number",
"default": 0
},
{
"name": "rank",
"label": "Ranks",
"id": "rank",
"name": "Ranks",
"type": "select",
"helpText": "Filter statements by rank",
"choices": [
Expand All @@ -39,8 +39,8 @@
"default": "best"
},
{
"name": "references",
"label": "References",
"id": "references",
"name": "References",
"type": "select",
"helpText": "Filter statements by their references",
"choices": [
Expand All @@ -60,8 +60,8 @@
"default": "any"
},
{
"name": "count",
"label": "Return counts instead of values",
"id": "count",
"name": "Return counts instead of values",
"helpText": "The number of values will be returned.",
"type": "checkbox",
"default": false
Expand Down
8 changes: 4 additions & 4 deletions draft/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,10 +818,10 @@ <h3>Data Extension Metadata</h3>
<p>
A <dfn>data extension property setting</dfn> consists of:
<dl>
<dt><code>name</code></dt>
<dd>A name for the setting, which identifies the setting uniquely;</dd>
<dt><code>label</code></dt>
<dd>A human-readable label, which is used when presenting the setting to the user in a form;</dd>
<dt><code>id</code></dt>
<dd>A unique identifier for the setting;</dd>
<dt><code>name</code></dt>
<dd>A human-readable name, which is used when presenting the setting to the user in a form;</dd>
<dt><code>type</code></dt>
<dd>A data type, which can be one of the strings <code>"number"</code>, <code>"text"</code>, <code>"checkbox"</code>, or <code>"select"</code>. This determines which type of value the property setting is expected to store: clients SHOULD render this setting with the corresponding HTML element;</li>
<dt><code>default</code></dt>
Expand Down
16 changes: 8 additions & 8 deletions draft/schemas/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
"default": {
"type": "number"
},
"label": {
"id": {
"type": "string"
},
"name": {
Expand All @@ -140,7 +140,7 @@
},
"required": [
"type",
"label",
"id",
"name"
]
},
Expand All @@ -157,7 +157,7 @@
"default": {
"type": "string"
},
"label": {
"id": {
"type": "string"
},
"name": {
Expand All @@ -169,7 +169,7 @@
},
"required": [
"type",
"label",
"id",
"name"
]
},
Expand All @@ -186,7 +186,7 @@
"default": {
"type": "boolean"
},
"label": {
"id": {
"type": "string"
},
"name": {
Expand All @@ -198,7 +198,7 @@
},
"required": [
"type",
"label",
"id",
"name"
]
},
Expand All @@ -215,7 +215,7 @@
"default": {
"type": "string"
},
"label": {
"id": {
"type": "string"
},
"name": {
Expand Down Expand Up @@ -245,7 +245,7 @@
},
"required": [
"type",
"label",
"id",
"name",
"choices"
]
Expand Down
Loading