Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recurly nokogiri deprecation warnings #754

Open
jcw- opened this issue Feb 27, 2022 · 1 comment
Open

Recurly nokogiri deprecation warnings #754

jcw- opened this issue Feb 27, 2022 · 1 comment
Labels
question

Comments

@jcw-
Copy link

jcw- commented Feb 27, 2022

Attempting to upgrade nokogiri to 1.13.3 results in the following deprecation message from the Recurly gem (API v2):

lib/recurly/xml/nokogiri.rb:11: warning: Passing a Node as the second parameter to Node.new is deprecated. Please pass a Document instead, or prefer an alternative constructor like Node#add_child. This will become an error in a future release of Nokogiri.

Would this be something that might get addressed in a future release on the v2 branch?
@jcw- jcw- added the question label Feb 27, 2022
Merged
@carlosantoniodasilva
Copy link

I have opened a PR #773 that should remove the warning, let me know if that ends up not working for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carlosantoniodasilva @jcw-