bundle: Implement changes for bundle generation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhu-1
reviewed
Jul 1, 2024
|
/assign @nb-ohad |
iamniting
commented
Jul 2, 2024
Madhu-1
reviewed
Jul 2, 2024
Madhu-1
reviewed
Jul 2, 2024
Madhu-1
requested changes
Jul 4, 2024
Makefile.ds
Outdated
| # bundle should use a different PACKAGE_NAME to prevent conflicts. | ||
| PACKAGE_NAME ?= ceph-csi-operator | ||
|
|
||
| # Creating the New CatalogSource requires publishing CSVs that replace one Operator, |
There was a problem hiding this comment.
This is not done yet, can you please check
There was a problem hiding this comment.
oops, It is changed now.
iamniting
force-pushed
the
csv-ds
branch
5 times, most recently
from
ebe3813 to
8d2b05c
Compare
Madhu-1
reviewed
Jul 4, 2024
|
Can you please take a look at the CI and make specific changes in the upstream for codespell to skip this folder as well |
iamniting
force-pushed
the
csv-ds
branch
2 times, most recently
from
a5df486 to
4028a76
Compare
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
Madhu-1
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
@iamniting should we add a github action to downstream to run this to keep the manifest updated?
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
This PR adds logic for the bundle generation and related make targets.
Is there anything that requires special attention
Do you have any questions?
Is the change backward compatible?
Are there concerns around backward compatibility?
Provide any external context for the change, if any.
For example:
Related issues
Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.
Fixes: #issue_number
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.