Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFBUGS-942: csiaddons: add rbac permission to delete the csiaddons obj #63

Conversation

rewantsoni
Copy link
Member

This is a backport PR of ceph#182 to 4.18 branch, This is already synced to downstream main branch

@rewantsoni
Copy link
Member Author

/retitle DFBUG-942: csiaddons: add rbac permission to delete the csiaddons obj

@openshift-ci openshift-ci bot changed the title csiaddons: add rbac permission to delete the csiaddons obj DFBUG-942: csiaddons: add rbac permission to delete the csiaddons obj Nov 27, 2024
@openshift-ci-robot
Copy link

@rewantsoni: No Jira issue with key DFBUG-942 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

This is a backport PR of ceph#182 to 4.18 branch, This is already synced to downstream main branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rewantsoni
Copy link
Member Author

rewantsoni commented Nov 27, 2024

/retitle DFBUGS-942: csiaddons: add rbac permission to delete the csiaddons obj

@openshift-ci openshift-ci bot changed the title DFBUG-942: csiaddons: add rbac permission to delete the csiaddons obj DFBUGS-942: csiaddons: add rbac permission to delete the csiaddons obj Nov 27, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Nov 27, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 27, 2024

@rewantsoni: This pull request references [Jira Issue DFBUGS-942](https://issues.redhat.com//browse/DFBUGS-942), which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jilju

In response to this:

This is a backport PR of ceph#182 to 4.18 branch, This is already synced to downstream main branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Nov 27, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: jilju.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@rewantsoni: This pull request references [Jira Issue DFBUGS-942](https://issues.redhat.com//browse/DFBUGS-942), which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jilju

In response to this:

This is a backport PR of ceph#182 to 4.18 branch, This is already synced to downstream main branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

rewantsoni and others added 2 commits November 27, 2024 18:41
csiaddons needs delete permission for setting ownerRef

Signed-off-by: Rewant Soni <resoni@redhat.com>
(cherry picked from commit fcb8646)
add generated bundle changes

Signed-off-by: Ceph Jenkins <ceph-jenkins@redhat.com>
(cherry picked from commit 5fd5e66)
@rewantsoni rewantsoni force-pushed the downstream-permission branch from d95fb1a to cd3ec4f Compare November 27, 2024 13:11
@Madhu-1
Copy link
Member

Madhu-1 commented Nov 27, 2024

/lgtm
/approve

Copy link

openshift-ci bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhu-1, rewantsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 85cca80 into red-hat-storage:release-4.18 Nov 27, 2024
13 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 27, 2024

@rewantsoni: [Jira Issue DFBUGS-942](https://issues.redhat.com//browse/DFBUGS-942): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-942](https://issues.redhat.com//browse/DFBUGS-942) has been moved to the MODIFIED state.

In response to this:

This is a backport PR of ceph#182 to 4.18 branch, This is already synced to downstream main branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants