DFBUGS-1145: Update externalsnapshotter volumegroupsnapshot container arg #65
Conversation
In external-snapshotter the groupsnapshot feature flag is moved to a new container argument and the old enable-volumegroup-snapshot flag is removed, This PR updates the flag to use external-snapshotter latest version, Note:- As the flag is removed with Rook the user cannot test/use the older version of external-snapshotter for groupsnapshot feature, but all other features will be still supported with older releases. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com> (cherry picked from commit 6f4dc24)
updating the external-snapshotter image to the latest release. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com> (cherry picked from commit 810accd)
openshift-ci-robot
added
jira/valid-reference
|
@Madhu-1: This pull request references [Jira Issue DFBUGS-1145](https://issues.redhat.com//browse/DFBUGS-1145), which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: nehaberry. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
previously @Nikhil-Ladha mentioned that d/s automation will sync main daily and then we should raise a backport. |
Yes, I have triggered a sync job, will update here once complete. |
|
Sync PR is created #66 , I think we are good to close this PR now. |
|
This is a backport PR for 4.18 branch /hold cancel |
|
/assign @nb-ohad |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Madhu-1, nb-ohad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 8032744
into
red-hat-storage:release-4.18
|
@Madhu-1: [Jira Issue DFBUGS-1145](https://issues.redhat.com//browse/DFBUGS-1145): All pull requests linked via external trackers have merged: [Jira Issue DFBUGS-1145](https://issues.redhat.com//browse/DFBUGS-1145) has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This is a backport of ceph#179.
Note:- Keeping it on hold until the downstream main is synced with upstream main
/hold