Syncing latest changes from upstream main for ceph-csi-operator #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
design and api for the csi pods logrotate Signed-off-by: parth-gr <partharora1010@gmail.com>
logrotate: add design and api for logrotate
…on field to Rotation Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Driver API: Align type code to established order and rename LogRotation field to Rotation
- validate driver name structure - parse and split driver name into short name and driver type - load desired driver resource Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
…rge them Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Implement Driver API reconciliation
Bumps the k8s-dependencies group with 4 updates: [k8s.io/api](https://github.com/kubernetes/api), [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery), [k8s.io/client-go](https://github.com/kubernetes/client-go) and [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime). Updates `k8s.io/api` from 0.29.2 to 0.30.3 - [Commits](kubernetes/api@v0.29.2...v0.30.3) Updates `k8s.io/apimachinery` from 0.29.2 to 0.30.3 - [Commits](kubernetes/apimachinery@v0.29.2...v0.30.3) Updates `k8s.io/client-go` from 0.29.2 to 0.30.3 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.29.2...v0.30.3) Updates `sigs.k8s.io/controller-runtime` from 0.17.3 to 0.18.4 - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.17.3...v0.18.4) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: sigs.k8s.io/controller-runtime dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
…es-29417d4666 build(deps): bump the k8s-dependencies group with 4 updates
updating github action to run git diff to check uncommitted files. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
pushing the uncommitted files to the repo. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Bumps the github-dependencies group with 3 updates: [github.com/go-logr/logr](https://github.com/go-logr/logr), [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) and [github.com/onsi/gomega](https://github.com/onsi/gomega). Updates `github.com/go-logr/logr` from 1.4.1 to 1.4.2 - [Release notes](https://github.com/go-logr/logr/releases) - [Changelog](https://github.com/go-logr/logr/blob/master/CHANGELOG.md) - [Commits](go-logr/logr@v1.4.1...v1.4.2) Updates `github.com/onsi/ginkgo/v2` from 2.17.1 to 2.19.1 - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.17.1...v2.19.1) Updates `github.com/onsi/gomega` from 1.32.0 to 1.34.0 - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.32.0...v1.34.0) --- updated-dependencies: - dependency-name: github.com/go-logr/logr dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-dependencies - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
…ncies-b5f98b9a66 build(deps): bump the github-dependencies group with 3 updates
ci: update action to check git diff
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
fix bugs found in controller
Note: Design doc alignment will be provided in a future commit for all API changes together Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Note: Design doc alignment will be provided in a future commit for all API changes together Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
APIs: Rename "LogLevel" to "Verbosity"
ClientProfileMapping API: Create API definition and type for ClientProfileMapping API
Driver Controller: Fix support for SnapshotPolicy settings
Operands SA and RBAC will now be included in the product of "make build-installer" Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
adding dist to gitignore to avoid pushing files to the repo Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Configuration: Add CSI operand RBAC kustomization file
as we have scripts in the repo add a shell check for the same. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Add the scripts to build, deploy and test the operator state and cleanup the deployment at last. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Signed-off-by: sp98 <sapillai@redhat.com>
Use list of BlockPoolMapping in clientProfileMappings spec
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Update ci test
…scheme Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
… related ceph connection Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
…ientProfile resource Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
APIs: Additional validations
ClientProfile reconcile
1. While setting SELinuxMount on CSIDriver we need to check for existence
of value set in Nodeplugin before using it or else CSIDriver will
reconile infinitely due to a spurious diff
```
(dlv) p desiredCsiDriver.Spec
k8s.io/api/storage/v1.CSIDriverSpec {
AttachRequired: *true,
PodInfoOnMount: *false,
VolumeLifecycleModes: []k8s.io/api/storage/v1.VolumeLifecycleMode len: 1, cap: 1, [
"Persistent",
],
StorageCapacity: *false,
FSGroupPolicy: *"File",
TokenRequests: []k8s.io/api/storage/v1.TokenRequest len: 0, cap: 0, nil,
RequiresRepublish: *false,
SELinuxMount: *bool nil,} <=====>
(dlv) p existingCsiDriver.Spec
k8s.io/api/storage/v1.CSIDriverSpec {
AttachRequired: *true,
PodInfoOnMount: *false,
VolumeLifecycleModes: []k8s.io/api/storage/v1.VolumeLifecycleMode len: 1, cap: 1, [
"Persistent",
],
StorageCapacity: *false,
FSGroupPolicy: *"File",
TokenRequests: []k8s.io/api/storage/v1.TokenRequest len: 0, cap: 0, nil,
RequiresRepublish: *false,
SELinuxMount: *false,} <=====>
```
2. We need to mount csi configmap in Nodeplugin as well
3. Topology feature gate should be `false` by default
4. Fix typo in CSI plugin roles
Signed-off-by: Leela Venkaiah G <lgangava@ibm.com>
controllers: fix issues found in recent testing
Fall back to recreate (delete then create) in the rear case we need to change an immutable field Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Bumps the github-dependencies group with 1 update: [github.com/onsi/gomega](https://github.com/onsi/gomega). Updates `github.com/onsi/gomega` from 1.34.0 to 1.34.1 - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.34.0...v1.34.1) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
Driver Controller: Use CreateOrUpdate for k8s CSIDriver reconciliation
…endencies-20bee1a956 build(deps): bump github.com/onsi/gomega from 1.34.0 to 1.34.1 in the github-dependencies group
iamniting
approved these changes
Aug 6, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: df-build-team, iamniting The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream main branch