Syncing latest changes from upstream main for ceph-csi-operator #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add auto generated dockerfile to gitignore so that we dont need to it push to repo. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Adding a github action to build and push docker image to quay Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
add a missing `,` inside the json tag or else it is considering inside as a new field in the spec. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
fix inline in json
This PR exposes a new fields in the nodeplugin spec where user can specify the domain labels for the cephcsi to advertise its topology domain fixes: ceph#80 Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
api: add support for topology based provisioning
fix different problem found during testing for the csiaddons. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
ci: github action for docker build push
fix: address csi addons problems in csi
Remove commented out quay login which is required to push image and also remove step to print env. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
updated the validation rule for configmap name to work for all kubernetes versions. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
ci: fix problem in build-push action
Driver Controller: remove empty container arguments
improve logging to log both actual and exepect details which helps for debugging. fixes: #53 Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
impore logging for invalid driver name
Signed-off-by: Divyansh Kamboj <dkamboj@redhat.com>
update validation rule for confimap name
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
api: make apis into a seperate package
Driver Controller: Fix nil ref access and remove unnecessary mem copy
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Driver Controller: Ensure CSI Config Creation
there was cameCase type in SnapshotPolicyType enum validation. Signed-off-by: subhamkrai <srai@redhat.com>
api: fix camelCase issue SnapshotPolicyType
we have seen the issues in other project where api is having controller runtime as dependency eventhrouh the main project importing the operator doesnt have the dependency on controller runtime directly now they need to wait for it to update to other kubernetes version as well. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
remove controller runtime dependency
kubernetes doesnt allow to have any special chars other than `-` in the names, we need to replace all special char what we allow with `-` for service names. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
generate service name as per kubernetes
Madhu-1
approved these changes
Aug 8, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: df-build-team, Madhu-1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream main branch