forked from csi-addons/kubernetes-csi-addons
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.15] Syncing latest changes from upstream main for kubernetes-csi-addons #107
Merged
openshift-merge-bot
merged 10 commits into
red-hat-storage:release-4.15
from
openshift-cherrypick-robot:cherry-pick-106-to-release-4.15
Dec 19, 2023
Merged
[release-4.15] Syncing latest changes from upstream main for kubernetes-csi-addons #107
openshift-merge-bot
merged 10 commits into
red-hat-storage:release-4.15
from
openshift-cherrypick-robot:cherry-pick-106-to-release-4.15
Dec 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new `NormalizeLeaseName()` function can be used to convert a drivername to an acceptible name for a Kubernetes Lease object. Signed-off-by: Niels de Vos <ndevos@ibm.com>
…holder Signed-off-by: Niels de Vos <ndevos@ibm.com>
When a CSI-driver provides the CONTROLLER_SERVICE capability, the sidecar will try to become the leader by obtaining a Lease based on the name of the CSI-driver. Signed-off-by: Niels de Vos <ndevos@ibm.com>
NetworkFence operations should only be sent to a CSI-Addons sidecar that has the CONTROLLER_SERVICE capability. There should be a single leader for the CSI-Addons sidecars that support that, and the leader can be identified by the Lease object for the CSI-drivername. Signed-off-by: Niels de Vos <ndevos@ibm.com>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v4...v5)
The CSIAddonsNode objects are located in the Namespace where CSI-drivers are running. Use this Namespace in the Connection struct, so that the Lease for a group of CSI-Addons ControllerServers can be found. Updates: csi-addons#422 Signed-off-by: Niels de Vos <ndevos@ibm.com>
Just like NetworkFence operations should be sent to a preferred Controller Server, VolumeReplication operations should be sent there as well. Updates: csi-addons#422 Signed-off-by: Niels de Vos <ndevos@ibm.com>
…ontroller Just like NetworkFence operations should be sent to a preferred Controller Server, the OFFLINE ReclaimSpace operations should be sent there as well. Updates: csi-addons#422 Signed-off-by: Niels de Vos <ndevos@ibm.com>
Bumps the golang-dependencies group with 1 update: [google.golang.org/grpc](https://github.com/grpc/grpc-go). - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.59.0...v1.60.0)
Bumps the k8s-dependencies group with 2 updates: [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) and [k8s.io/client-go](https://github.com/kubernetes/client-go). Updates `k8s.io/apimachinery` from 0.28.4 to 0.29.0 - [Commits](kubernetes/apimachinery@v0.28.4...v0.29.0) Updates `k8s.io/client-go` from 0.28.4 to 0.29.0 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.28.4...v0.29.0)
/cc @nixpanic |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nixpanic, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit Dec 19, 2023
8190460
into
red-hat-storage:release-4.15
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #106
/assign Rakshith-R