Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFBUGS-850: Reflect cephrbd image health in VR and VRG status #236

Open
wants to merge 3 commits into
base: release-4.17
Choose a base branch
from
Open

DFBUGS-850: Reflect cephrbd image health in VR and VRG status #236

wants to merge 3 commits into from

Conversation

nixpanic
Copy link
Member

Backport of three commits for improving the reported condition. All commits are part of the release-4.18 branch already.

/cc Madhu-1 Rakshith-R yati1998

Madhu-1 and others added 3 commits November 15, 2024 17:41
@Madhu-1 @nixpanic
replication: move conditions to api
54274fc 
The consumers of the Replication API
are expecting the conditions to be
something imported and comparable
from the other repo's. For the same
reason moving the conditions to replication
types.

fixes: csi-addons#649

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 89d4c5b)
Signed-off-by: Niels de Vos <ndevos@ibm.com>
@Rakshith-R @nixpanic
replication: add new Validated condition
53bf36d 
This commit adds new Validated condition.
This is initially used to indicate the csi driver
responded with FailedPrecondition grpc code for
EnableReplication request using
`PrerequisiteNotMet` reason.

Signed-off-by: Rakshith R <rar@redhat.com>
(cherry picked from commit 9f416da)
Signed-off-by: Niels de Vos <ndevos@ibm.com>
@yati1998 @nixpanic
update the volumereplication condition
0e29892 
this commit updates the volumereplication conditions to
include descriptive message for every
operations

Signed-off-by: yati1998 <ypadia@redhat.com>
(cherry picked from commit 8b610a1)
Signed-off-by: Niels de Vos <ndevos@ibm.com>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 15, 2024 •
edited by openshift-ci bot
Loading

@nixpanic: This pull request references [Jira Issue DFBUGS-850](https://issues.redhat.com//browse/DFBUGS-850), which is invalid:

  • expected the bug to target the "odf-4.17.1" version, but no target version was set
  • expected [Jira Issue DFBUGS-850](https://issues.redhat.com//browse/DFBUGS-850) to depend on a bug targeting a version in odf-4.18, odf-4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Backport of three commits for improving the reported condition. All commits are part of the release-4.18 branch already.

/cc Madhu-1 Rakshith-R yati1998

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm label Nov 17, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nixpanic, yati1998

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Madhu-1
Copy link
Member

Madhu-1 commented Nov 27, 2024

@nixpanic @yati1998 is this required for 4.17?

@nixpanic
Copy link
Member Author

nixpanic commented Nov 28, 2024 •
edited by openshift-ci bot
Loading

@nixpanic @yati1998 is this required for 4.17?

That is what DFBUGS-850 requests. It helps with troubleshooting, and therefor improved the supportability and user experience.

@nixpanic
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 28, 2024 •
edited by openshift-ci bot
Loading

@nixpanic: This pull request references [Jira Issue DFBUGS-850](https://issues.redhat.com//browse/DFBUGS-850), which is invalid:

  • expected the bug to target the "odf-4.17.1" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@nirs
Copy link

nirs commented Dec 4, 2024

Adding myself so I get notified when this is released. We need to consume this release in ramen for 4.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yati1998 yati1998 yati1998 approved these changes

@Madhu-1 Madhu-1 Awaiting requested review from Madhu-1

@Rakshith-R Rakshith-R Awaiting requested review from Rakshith-R

Assignees

@yati1998 yati1998

Labels
approved jira/invalid-bug jira/valid-reference lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nixpanic @openshift-ci-robot @Madhu-1 @nirs @yati1998 @Rakshith-R