Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from upstream main for kubernetes-csi-addons #243

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

df-build-team
Copy link

PR containing the latest commits from upstream main branch

The pod is set as the owner of the csiaddons
node object, and when the owner pod is deleted
the csiaddons need to be deleted as well, When
the delete Reconciles happens we cannot get the
pod deletails to resolve the endpoint and we dont
need that as well when we are deleting the CR.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@df-build-team df-build-team requested a review from a team December 5, 2024 07:55
@Madhu-1
Copy link
Member

Madhu-1 commented Dec 5, 2024

/lgtm
/approve

Copy link

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: df-build-team, Madhu-1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 5, 2024
@Madhu-1
Copy link
Member

Madhu-1 commented Dec 5, 2024

/cherry-pick release-4.18

@openshift-cherrypick-robot

@Madhu-1: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 2c23c0a into main Dec 5, 2024
20 checks passed
@openshift-cherrypick-robot

@Madhu-1: new pull request created: #244

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants