Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for Kube Object Sync time before running failover for Discovered Apps #10618

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

prsurve
Copy link
Contributor

@prsurve prsurve commented Oct 7, 2024

…d Apps

@prsurve prsurve added the DR Metro and Regional DR related PRs label Oct 7, 2024
@prsurve prsurve requested review from a team as code owners October 7, 2024 07:18
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Oct 7, 2024
@prsurve prsurve added the Verified Mark when PR was verified and log provided label Oct 7, 2024
am-agrawa
am-agrawa previously approved these changes Oct 14, 2024
Copy link

openshift-ci bot commented Oct 17, 2024

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prsurve

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
Copy link

openshift-ci bot commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prsurve

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

logger.info("Running Relocate Steps")
wait_time = 2 * scheduling_interval # Time in minutes
logger.info(f"Waiting for {wait_time} minutes to run IOs")
sleep(wait_time * 60)

logger.info("Checking for lastKubeObjectProtectionTime")
dr_helpers.verify_last_kubeobject_protection_time(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This verification should be added after relocate operation too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes you are right

…d Apps

Signed-off-by: prsurve <prsurve@redhat.com>
…d Apps

Signed-off-by: prsurve <prsurve@redhat.com>
Signed-off-by: prsurve <prsurve@redhat.com>
Signed-off-by: prsurve <prsurve@redhat.com>
Signed-off-by: prsurve <prsurve@redhat.com>
Signed-off-by: prsurve <prsurve@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DR Metro and Regional DR related PRs size/M PR that changes 30-99 lines Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants