Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Rotational duplicate in LocalVolumeSet #10694

Conversation

vavuthu
Copy link
Contributor

@vavuthu vavuthu commented Oct 16, 2024

Signed-off-by: vavuthu vavuthu@redhat.com

Signed-off-by: vavuthu <vavuthu@redhat.com>
@vavuthu vavuthu requested a review from a team as a code owner October 16, 2024 11:23
@vavuthu vavuthu added the team/ecosystem Ecosystem team related issues/PRs label Oct 16, 2024
Copy link

openshift-ci bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dahorak, petr-balogh, vavuthu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vsan_lso_vmdk_3m_3w.yaml
PR Test Suite: deployment
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job PASSED.

@vavuthu
Copy link
Contributor Author

vavuthu commented Oct 17, 2024

from logs

2024-10-17 15:41:45  kind: LocalVolumeSet
2024-10-17 15:41:45  metadata:
2024-10-17 15:41:45    name: localblock
2024-10-17 15:41:45    namespace: openshift-local-storage
2024-10-17 15:41:45  spec:
2024-10-17 15:41:45    deviceInclusionSpec:
2024-10-17 15:41:45      deviceMechanicalProperties:
2024-10-17 15:41:45      - NonRotational
2024-10-17 15:41:45      - Rotational
2024-10-17 15:41:45      deviceTypes:

@vavuthu vavuthu added the Verified Mark when PR was verified and log provided label Oct 17, 2024
@vavuthu vavuthu merged commit 596f384 into red-hat-storage:master Oct 17, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/XS team/ecosystem Ecosystem team related issues/PRs Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants