add ocp install log, delete cluster

[DanielOsypenko]

1. tuned create_openshift_install_log_file and added to rosahcp
2. added delete resources such as oidc-config, account-roles, etc into destroy_cluster

[DanielOsypenko]

All cycle is clean -
https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-deploy-ocs-cluster/43365/console - deploy + test
https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-destroy-ocs-cluster/49339/console -
destroy

username is updated from static kubeconfig
password is displayed

[dahorak]

Overall LGTM, I would just propose to update the message in the .openshift_install.log to make it more generic also for other types of deployment, not only via Assisted Installer.

[dahorak]

It might be worth to update this line based on the deployment type (or make it more generic), as this is not true for all the cases.

[DanielOsypenko]

I did not change this line, I only pushed create_openshift_install_log_file function to common space from ocs_ci/deployment/assisted_installer.py
as far as I understand it is a mock-up for our log-parser on Jenkins pipelines.

TBH, correcting code(mocked-up log message) for our custom-built pipelines that are not validating this log message other than retrieving the console should have a very low priority. Until it can be important for something else.

[dahorak]

For the Jenkins job, the important line is only the last one ... Access the OpenShift web-console here ....

The think is, that initially it was used only for the Assisted Installer deployment, where it make sense the message, but since you are moving it to the common space and re-using it for the ROSA deployment also, it will be worth to update the message to avoid confusion.
I think it is not necessary to make it dynamic based on the actual deployment type, but just more generic. What about something like this?

"Cluster is deployed via some kind of managed deployment (Assisted Installer API or ROSA). OpenShift Installer (IPI or UPI deployment) were not used!\n"

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dahorak, DanielOsypenko, jilju

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment