-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ocp install log, delete cluster #10703
Merged
dahorak
merged 5 commits into
red-hat-storage:master
from
DanielOsypenko:rosa_hcp_deploy_and_destroy_leftovers
Oct 23, 2024
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2346f9f
add ocp install log, delete cluster
DanielOsypenko 7c9977c
add username file for rosa, for jenkins console
DanielOsypenko 7f262fd
delete resources. old issues with clsuter_id were fixed
DanielOsypenko b86e840
extended timeout to create clsuter
DanielOsypenko 7872cb8
logmessage changed
DanielOsypenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth to update this line based on the deployment type (or make it more generic), as this is not true for all the cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not change this line, I only pushed create_openshift_install_log_file function to common space from ocs_ci/deployment/assisted_installer.py
as far as I understand it is a mock-up for our log-parser on Jenkins pipelines.
TBH, correcting code(mocked-up log message) for our custom-built pipelines that are not validating this log message other than retrieving the console should have a very low priority. Until it can be important for something else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the Jenkins job, the important line is only the last one
... Access the OpenShift web-console here ...
.The think is, that initially it was used only for the Assisted Installer deployment, where it make sense the message, but since you are moving it to the common space and re-using it for the ROSA deployment also, it will be worth to update the message to avoid confusion.
I think it is not necessary to make it dynamic based on the actual deployment type, but just more generic. What about something like this?