-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBM Cloud node stop and start added #10707
base: master
Are you sure you want to change the base?
IBM Cloud node stop and start added #10707
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gayathrimenath-ibm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ocs_ci/ocs/platform_nodes.py
Outdated
wait (bool): True for waiting the instances to stop, False otherwise | ||
|
||
""" | ||
self.ibmcloud.start_nodes(nodes, wait=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be stop_nodes ?
self.ibmcloud.start_nodes(nodes, wait=True) | |
self.ibmcloud.stop_nodes(nodes, wait=True) |
|
||
Args: | ||
nodes (list): The OCS objects of the nodes | ||
wait (bool): True for waiting the instances to start, False otherwise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Raises
section mention: ValueError
there as this is one you raises in some cases ;)
ocs_ci/utility/ibmcloud.py
Outdated
raise ValueError("No nodes found to start") | ||
|
||
node_names = [n.name for n in nodes] | ||
self.ibmcloud.restart_nodes(nodes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.ibmcloud.restart_nodes(nodes) | |
self.restart_nodes(nodes) |
Did you forgot to remove ibmcloud
here?
No description provided.