IBM Cloud node stop and start added #10707
Open
+83
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gayathrimenath-ibm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
petr-balogh
reviewed
Oct 21, 2024
ocs_ci/ocs/platform_nodes.py
Outdated
| wait (bool): True for waiting the instances to stop, False otherwise | ||
|
|
||
| """ | ||
| self.ibmcloud.start_nodes(nodes, wait=True) |
There was a problem hiding this comment.
Should this be stop_nodes ?
Suggested change
| self.ibmcloud.start_nodes(nodes, wait=True) | |
| self.ibmcloud.stop_nodes(nodes, wait=True) |
|
|
||
| Args: | ||
| nodes (list): The OCS objects of the nodes | ||
| wait (bool): True for waiting the instances to start, False otherwise |
There was a problem hiding this comment.
Add Raises section mention: ValueError there as this is one you raises in some cases ;)
ocs_ci/utility/ibmcloud.py
Outdated
| raise ValueError("No nodes found to start") | ||
|
|
||
| node_names = [n.name for n in nodes] | ||
| self.ibmcloud.restart_nodes(nodes) |
There was a problem hiding this comment.
Suggested change
| self.ibmcloud.restart_nodes(nodes) | |
| self.restart_nodes(nodes) |
Did you forgot to remove ibmcloud here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.