-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBM Cloud node stop and start added #10707
Open
gayathrimenath-ibm
wants to merge
3
commits into
red-hat-storage:master
Choose a base branch
from
gayathrimenath-ibm:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+83
−3
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -25,6 +25,7 @@ | |||||
NodeHasNoAttachedVolume, | ||||||
TimeoutExpiredError, | ||||||
) | ||||||
from ocs_ci.ocs.node import wait_for_nodes_status | ||||||
from ocs_ci.ocs.resources.ocs import OCS | ||||||
from ocs_ci.utility import version as util_version | ||||||
from ocs_ci.utility.utils import get_infra_id, get_ocp_version, run_cmd, TimeoutSampler | ||||||
|
@@ -337,6 +338,52 @@ class IBMCloud(object): | |||||
Wrapper for Ibm Cloud | ||||||
""" | ||||||
|
||||||
def start_nodes(self, nodes, wait=True): | ||||||
""" | ||||||
Start nodes on IBM Cloud. | ||||||
|
||||||
Args: | ||||||
nodes (list): The OCS objects of the nodes | ||||||
wait (bool): True for waiting the instances to start, False otherwise | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add |
||||||
|
||||||
""" | ||||||
if not nodes: | ||||||
raise ValueError("No nodes found to start") | ||||||
|
||||||
node_names = [n.name for n in nodes] | ||||||
self.ibmcloud.restart_nodes(nodes) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Did you forgot to remove |
||||||
|
||||||
if wait: | ||||||
# When the node is reachable then the node reaches status Ready. | ||||||
logger.info(f"Waiting for nodes: {node_names} to reach ready state") | ||||||
wait_for_nodes_status( | ||||||
node_names=node_names, status=constants.NODE_READY, timeout=180, sleep=5 | ||||||
) | ||||||
|
||||||
def stop_nodes(self, nodes, wait=True): | ||||||
""" | ||||||
Stop nodes on IBM Cloud | ||||||
|
||||||
Args: | ||||||
nodes (list): The OCS objects of the nodes | ||||||
wait (bool): True for waiting the instances to stop, False otherwise | ||||||
|
||||||
""" | ||||||
if not nodes: | ||||||
raise ValueError("No nodes found to stop") | ||||||
|
||||||
cmd = "oc debug node/{} -- chroot /host shutdown" | ||||||
node_names = [n.name for n in nodes] | ||||||
for node in node_names: | ||||||
run_cmd(cmd.format(node)) | ||||||
|
||||||
if wait: | ||||||
# When the node is reachable then the node reaches status Ready. | ||||||
logger.info(f"Waiting for nodes: {node_names} to reach not ready state") | ||||||
wait_for_nodes_status( | ||||||
node_names, constants.NODE_NOT_READY, timeout=180, sleep=5 | ||||||
) | ||||||
|
||||||
def restart_nodes(self, nodes, timeout=900, wait=True): | ||||||
""" | ||||||
Reboot the nodes on IBM Cloud. | ||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be stop_nodes ?