Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create image nginx with FIO #8465

Merged
merged 5 commits into from
Nov 23, 2023
Merged

Conversation

OdedViner
Copy link
Contributor

@OdedViner OdedViner commented Sep 12, 2023

In our tests, we create an NGINX pod and then Install FIO [via oc rsh cmd]
Created a nginx:alpine image with FIO and build it with multi-architecture support.
Now, we do not need to install FIO on the existing pod [save running time]

  1. Install Docker Buildx if you haven't already:
docker buildx version  # Check if it's already installed
docker buildx create --use
  1. Create a Dockerfile for NGINX:
# Use a base image with QEMU for multi-architecture support
FROM --platform=$BUILDPLATFORM nginx:alpine

RUN apk update 
RUN apk upgrade
RUN apk add fio bash
  1. Build and Push the multi-architecture Docker image using Docker Buildx:
 docker buildx build --platform linux/amd64,linux/ppc64le,linux/s390x,linux/arm64 -t quay.io/ocsci/nginx:fio . --push

I saved the image on the same registry and changed the tag to fio
https://quay.io/repository/ocsci/nginx?tab=tags

@OdedViner OdedViner requested a review from a team as a code owner September 12, 2023 14:07
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Sep 12, 2023
if self.pod:
setup_conf["pod"] = self.pod
return self.work_load_mod.setup(**setup_conf)
# def setup(self, **setup_conf):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this affect the non-nginx pods ?

Copy link
Contributor Author

@OdedViner OdedViner Sep 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shylesh What do you think? we are using Debian only for NGINX.. correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@pull-request-size pull-request-size bot added size/S PR that changes 10-29 lines size/M PR that changes 30-99 lines and removed size/M PR that changes 30-99 lines size/S PR that changes 10-29 lines labels Sep 28, 2023
Signed-off-by: oviner <oviner@redhat.com>
Signed-off-by: oviner <oviner@redhat.com>
Signed-off-by: oviner <oviner@redhat.com>
Signed-off-by: oviner <oviner@redhat.com>
@pull-request-size pull-request-size bot added size/S PR that changes 10-29 lines and removed size/M PR that changes 30-99 lines labels Sep 28, 2023
Signed-off-by: oviner <oviner@redhat.com>
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: acceptance
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link
Contributor

@shylesh shylesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Nov 23, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: OdedViner, petr-balogh, shylesh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@petr-balogh petr-balogh merged commit b137385 into red-hat-storage:master Nov 23, 2023
5 of 7 checks passed
@OdedViner
Copy link
Contributor Author

/cherry-pick release-4.14

@OdedViner
Copy link
Contributor Author

/cherry-pick release-4.13

@OdedViner
Copy link
Contributor Author

/cherry-pick release-4.12

@openshift-cherrypick-robot
Copy link
Collaborator

@OdedViner: new pull request created: #8929

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Collaborator

@OdedViner: new pull request created: #8930

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Collaborator

@OdedViner: new pull request created: #8931

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@OdedViner
Copy link
Contributor Author

/cherry-pick release-4.14

@OdedViner
Copy link
Contributor Author

/cherry-pick release-4.13

@OdedViner
Copy link
Contributor Author

/cherry-pick release-4.12

@openshift-cherrypick-robot
Copy link
Collaborator

@OdedViner: new pull request could not be created: failed to create pull request against red-hat-storage/ocs-ci#release-4.14 from head openshift-cherrypick-robot:cherry-pick-8465-to-release-4.14: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-8465-to-release-4.14."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Collaborator

@OdedViner: new pull request could not be created: failed to create pull request against red-hat-storage/ocs-ci#release-4.13 from head openshift-cherrypick-robot:cherry-pick-8465-to-release-4.13: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-8465-to-release-4.13."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Collaborator

@OdedViner: new pull request could not be created: failed to create pull request against red-hat-storage/ocs-ci#release-4.12 from head openshift-cherrypick-robot:cherry-pick-8465-to-release-4.12: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-8465-to-release-4.12."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@petr-balogh petr-balogh added the team/ecosystem Ecosystem team related issues/PRs label Dec 5, 2023
@abdulkandathil
Copy link

@OdedViner The new tag is not compatible with s390x architecture.. could you please rebuild the image..

Events:
  Type     Reason                  Age               From                     Message
  ----     ------                  ----              ----                     -------
  Normal   Scheduled               24s               default-scheduler        Successfully assigned namespace-test-b65c47a619054820aebf22c9d/pod-test-rbd-0ff1cfb74f8e46baa38dfde8d8c to worker-1.ocsm1301001.lnxero1.boe
  Normal   SuccessfulAttachVolume  24s               attachdetach-controller  AttachVolume.Attach succeeded for volume "pvc-45553ae9-1d7e-48e8-bff0-964eba77420c"
  Normal   AddedInterface          20s               multus                   Add eth0 [10.131.0.110/23] from openshift-sdn
  Normal   Pulled                  4s (x3 over 20s)  kubelet                  Container image "quay.io/ocsci/nginx:fio" already present on machine
  Normal   Created                 4s (x3 over 20s)  kubelet                  Created container web-server
  Normal   Started                 4s (x3 over 20s)  kubelet                  Started container web-server
  Warning  BackOff                 3s (x3 over 18s)  kubelet                  Back-off restarting failed container web-server in pod pod-test-rbd-0ff1cfb74f8e46baa38dfde8d8c_namespace-test-b65c47a619054820aebf22c9d(d2b4ffb9-da47-4c1c-a0cb-e6ec6ef0c1ee)
[root@m1301001 ~]# oc -n namespace-test-b65c47a619054820aebf22c9d logs pod-test-rbd-0ff1cfb74f8e46baa38dfde8d8c
exec /docker-entrypoint.sh: exec format error
[root@m1301001 ~]#

OdedViner added a commit to OdedViner/ocs-ci that referenced this pull request May 15, 2024
* Create image nginx with FIO

Signed-off-by: oviner <oviner@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/S PR that changes 10-29 lines team/ecosystem Ecosystem team related issues/PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants