-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create image nginx with FIO #8465
Conversation
ocs_ci/ocs/workload.py
Outdated
if self.pod: | ||
setup_conf["pod"] = self.pod | ||
return self.work_load_mod.setup(**setup_conf) | ||
# def setup(self, **setup_conf): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this affect the non-nginx pods ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shylesh What do you think? we are using Debian only for NGINX.. correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OdedViner I see another reference https://github.com/red-hat-storage/ocs-ci/blob/master/ocs_ci/ocs/resources/pod.py#L541 which is jenkins workload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
d820382
to
67d4600
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master
Job UNSTABLE (some or all tests failed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name:
Cluster Configuration:
PR Test Suite: acceptance
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master
Job UNSTABLE (some or all tests failed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: OdedViner, petr-balogh, shylesh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-4.14 |
/cherry-pick release-4.13 |
/cherry-pick release-4.12 |
@OdedViner: new pull request created: #8929 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@OdedViner: new pull request created: #8930 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@OdedViner: new pull request created: #8931 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.14 |
/cherry-pick release-4.13 |
/cherry-pick release-4.12 |
@OdedViner: new pull request could not be created: failed to create pull request against red-hat-storage/ocs-ci#release-4.14 from head openshift-cherrypick-robot:cherry-pick-8465-to-release-4.14: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-8465-to-release-4.14."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@OdedViner: new pull request could not be created: failed to create pull request against red-hat-storage/ocs-ci#release-4.13 from head openshift-cherrypick-robot:cherry-pick-8465-to-release-4.13: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-8465-to-release-4.13."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@OdedViner: new pull request could not be created: failed to create pull request against red-hat-storage/ocs-ci#release-4.12 from head openshift-cherrypick-robot:cherry-pick-8465-to-release-4.12: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-8465-to-release-4.12."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@OdedViner The new tag is not compatible with s390x architecture.. could you please rebuild the image..
|
* Create image nginx with FIO Signed-off-by: oviner <oviner@redhat.com>
In our tests, we create an NGINX pod and then Install FIO [via
oc rsh
cmd]Created a
nginx:alpine
image with FIO and build it with multi-architecture support.Now, we do not need to install FIO on the existing pod [save running time]
I saved the image on the same registry and changed the tag to
fio
https://quay.io/repository/ocsci/nginx?tab=tags