-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Provider/Client] deploy Hosted OCP Cluster #9111
[Provider/Client] deploy Hosted OCP Cluster #9111
Conversation
78578cb
to
2c77c7c
Compare
aac5502
to
3cd0cfe
Compare
@@ -1067,6 +1130,7 @@ | |||
VSPHERE_PLATFORM = "vsphere" | |||
BAREMETAL_PLATFORM = "baremetal" | |||
IBM_POWER_PLATFORM = "powervs" | |||
IBM_CLOUD_BAREMETAL_PLATFORM = "ibm_cloud_baremetal" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking if we have to separate the baremetal
and ibm_cloud_baremetal
platforms?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename ibm_cloud_baremetal -> ibm_baremetal ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I meant if we could use the existing BAREMETAL_PLATFORM
? Or if there are some incompatible differences?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there maybe differences between baremetal and IBM baremetal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The question will be, how big the differences will be? For example in my PR #9451, I'm handling it as generic baremetal platform and the difference between the BM env in Octo lab and the IBM Cloud BM is in the mgmt_provider
, which controls if the BM machine is managed via ipmitool
or ibmcloud
command.
I don't know all the details there about the differences, so maybe it make sense to separate it like this - but if the differences are not too big, I would vote to keep it unified here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for node operations the differences are serious @yitzhak12 can confirm
conf/ocsci/provider_mode_ibm_cloud_baremetal_kubevirt_clients.yaml
Outdated
Show resolved
Hide resolved
611169e
to
5f236c4
Compare
conf/ocsci/provider_mode_ibm_cloud_baremetal_kubevirt_clients.yaml
Outdated
Show resolved
Hide resolved
conf/ocsci/provider_mode_ibm_cloud_baremetal_kubevirt_clients.yaml
Outdated
Show resolved
Hide resolved
59d3612
to
3d4d57d
Compare
Signed-off-by: Daniel Osypenko <dosypenk@redhat.com>
Signed-off-by: Daniel Osypenko <dosypenk@redhat.com>
Signed-off-by: Daniel Osypenko <dosypenk@redhat.com>
Signed-off-by: Daniel Osypenko <dosypenk@redhat.com>
Signed-off-by: Daniel Osypenko <dosypenk@redhat.com>
test run, deployment - Passed |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dahorak, DanielOsypenko, ebondare, fbalak The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR summary:
Automation for the Hosted cluster deployment on IBM Bare Metal Hosting(Management) clusters.
This PR includes:
vSphere is not supported officially, and Hosted cluster creation fails hence no successful testing is done