Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RDR] Enable ACM observability for DR monitoring dashboard on RHACM console #9646

Merged
merged 32 commits into from
Aug 6, 2024
Merged

[RDR] Enable ACM observability for DR monitoring dashboard on RHACM console #9646

merged 32 commits into from
Aug 6, 2024

Conversation

am-agrawa
Copy link
Contributor

@am-agrawa am-agrawa commented Apr 6, 2024 •
edited
Loading

Whitelist RDB metrics and enable ACM observability to access DR monitoring dashboard on the RHACM console.

Also fixes #9622

@am-agrawa am-agrawa self-assigned this Apr 6, 2024
@am-agrawa am-agrawa requested a review from a team as a code owner April 6, 2024 19:25
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Apr 6, 2024
@prsurve prsurve added the DR Metro and Regional DR related PRs label May 13, 2024
prsurve
prsurve reviewed May 13, 2024
View reviewed changes
ocs_ci/templates/DR/multiclusterobservability.yaml Outdated
name: thanos-object-storage
receiveStorageSize: 100Gi
ruleStorageSize: 1Gi
storageClass: thin-csi-odf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value should be configurable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@am-agrawa am-agrawa requested a review from a team May 17, 2024 11:31
@am-agrawa am-agrawa requested a review from a team May 29, 2024 14:40
@am-agrawa am-agrawa force-pushed the monitoring_dashboard branch 2 times, most recently from 6ed9c17 to 1040496 Compare June 4, 2024 17:33
@am-agrawa
Copy link
Contributor Author

Passed here- https://url.corp.redhat.com/d200c31

@am-agrawa am-agrawa added the Verified Mark when PR was verified and log provided label Jul 31, 2024
@openshift-ci openshift-ci bot removed the lgtm label Aug 5, 2024
prsurve
prsurve previously approved these changes Aug 6, 2024
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Aug 6, 2024
DanielOsypenko
DanielOsypenko reviewed Aug 6, 2024
View reviewed changes
ocs_ci/deployment/deployment.py Outdated
logger.info(
"Creating thanos.yaml needed for ACM observability after passing required params"
)
run_cmd(f"oc create -f {thanos_data_yaml.name}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run_cmd is a deprecated form of exec_cmd, we need to change replace it here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

DanielOsypenko
DanielOsypenko reviewed Aug 6, 2024
View reviewed changes
ocs_ci/deployment/deployment.py Outdated
"""

acm_observability_status = bool(
run_cmd(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run_cmd is a deprecated form of exec_cmd, we need to change replace it here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

DanielOsypenko
DanielOsypenko reviewed Aug 6, 2024
View reviewed changes
ocs_ci/deployment/deployment.py Outdated
multiclusterobservability_data_yaml.name,
)

run_cmd(f"oc create -f {multiclusterobservability_data_yaml.name}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run_cmd is a deprecated form of exec_cmd, we need to change replace it here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

DanielOsypenko
DanielOsypenko reviewed Aug 6, 2024
View reviewed changes
ocs_ci/deployment/deployment.py Outdated
logger.info(
"Add label for cluster-monitoring needed to fire VolumeSyncronizationDelayAlert on the Hub cluster"
)
run_cmd(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run_cmd is a deprecated form of exec_cmd, we need to change replace it here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

DanielOsypenko
DanielOsypenko reviewed Aug 6, 2024
View reviewed changes
ocs_ci/deployment/deployment.py Outdated
self.thanos_secret()

logger.info("Whitelist RBD metrics by creating configmap")
run_cmd(f"oc create -f {constants.OBSERVABILITYMETRICSCONFIGMAP_PATH}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run_cmd is a deprecated form of exec_cmd, we need to change replace it here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@am-agrawa
replace run_cmd to exec_cmd
6ab0598 
Signed-off-by: am-agrawa <amagrawa@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Aug 6, 2024
DanielOsypenko
DanielOsypenko previously approved these changes Aug 6, 2024
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Aug 6, 2024
@am-agrawa
doctext formatting
ba6ab91 
Signed-off-by: am-agrawa <amagrawa@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Aug 6, 2024
@openshift-ci openshift-ci bot added the lgtm label Aug 6, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: am-agrawa, ebondare, keesturam, sidhant-agrawal

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@keesturam keesturam merged commit 21d85b9 into master Aug 6, 2024
5 of 6 checks passed
@am-agrawa
Copy link
Contributor Author

/cherry-pick release-4.16

@openshift-cherrypick-robot
Copy link
Collaborator

@am-agrawa: new pull request created: #10261

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 7, 2024
Merged
@am-agrawa am-agrawa deleted the monitoring_dashboard branch August 7, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keesturam keesturam keesturam approved these changes

@sidhant-agrawal sidhant-agrawal sidhant-agrawal approved these changes

@ebondare ebondare ebondare approved these changes

@prsurve prsurve prsurve left review comments

@DanielOsypenko DanielOsypenko DanielOsypenko left review comments

Assignees

@keesturam keesturam

@sidhant-agrawal sidhant-agrawal

@prsurve prsurve

@ebondare ebondare

@DanielOsypenko DanielOsypenko

@am-agrawa am-agrawa

Labels
DR Metro and Regional DR related PRs lgtm size/L PR that changes 100-499 lines Squad/Turquoise Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
8 participants
@am-agrawa @sidhant-agrawal @openshift-cherrypick-robot @keesturam @prsurve @ebondare @DanielOsypenko @openshift-merge-robot