-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test CLI tool for disk replacement proceudre #9655
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bea9f23
WIP: Test CLI tool for disk replacement proceudre
OdedViner 5be6fc0
fix bin folder location based configuration
OdedViner 999e6df
fix code
OdedViner b599b26
fix code
OdedViner 735915d
fix code
OdedViner cb66f4c
change prompts_answers
OdedViner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,7 @@ | |
skipif_external_mode, | ||
skipif_managed_service, | ||
skipif_hci_provider_and_client, | ||
skipif_ocs_version, | ||
) | ||
from ocs_ci.helpers.sanity_helpers import Sanity | ||
from ocs_ci.helpers.helpers import ( | ||
|
@@ -236,3 +237,22 @@ def test_recovery_from_volume_deletion( | |
self.sanity_helpers.create_resources( | ||
pvc_factory, pod_factory, bucket_factory, rgw_bucket_factory | ||
) | ||
|
||
@bugzilla("2234479") | ||
@vsphere_platform_required | ||
@skipif_ocs_version("<4.15") | ||
@pytest.mark.polarion_id("OCS-5502") | ||
@skipif_external_mode | ||
def test_recovery_from_volume_deletion_cli_tool( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we want to still test both scenarios, mean without CLI Tool? As the TC test_recovery_from_volume_deletion will still get triggered as well. |
||
self, nodes, pvc_factory, pod_factory, bucket_factory, rgw_bucket_factory | ||
): | ||
""" | ||
Test cluster recovery from disk deletion from the platform side. | ||
Based on documented procedure detailed in | ||
https://bugzilla.redhat.com/show_bug.cgi?id=1823183 | ||
|
||
""" | ||
osd_operations.osd_device_replacement(nodes, cli_tool=True) | ||
self.sanity_helpers.create_resources( | ||
pvc_factory, pod_factory, bucket_factory, rgw_bucket_factory | ||
) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add a condition when there are no prompts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this case, we dont need to use this function