Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test resize OSD when one of the worker nodes got restarted or one of the resources got deleted in the middle of the process #9765

Merged

Conversation

yitzhak12
Copy link
Contributor

@yitzhak12 yitzhak12 commented May 6, 2024

The PR implements two small test cases as described in the OSD resize test plan:

  1. Test resize OSD when one of the worker nodes got restarted in the middle of the process.
  2. Test resize OSD when one of the resources got deleted in the middle of the process.

…des got restart in the middle of the process', 'Test resize OSD when one of the resources got deleted in the middle of the process'

Signed-off-by: Itzhak Kave <ikave@ibm.com>
@yitzhak12 yitzhak12 requested review from a team as code owners May 6, 2024 16:15
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label May 6, 2024
prsurve
prsurve previously approved these changes May 8, 2024
@@ -81,6 +86,19 @@ def setup(self, create_pvcs_and_pods):
pvc_size=pvc_size, num_of_rbd_pvc=5, num_of_cephfs_pvc=5
)

def basic_resize_osd_steps(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about moving this to ocs_ci.ocs.resources.osd_resize?

…d 'basic_resize_osd_steps' to the 'osd_resize' helper file

Signed-off-by: Itzhak Kave <ikave@ibm.com>
@pull-request-size pull-request-size bot added size/L PR that changes 100-499 lines and removed size/M PR that changes 30-99 lines labels May 9, 2024
@openshift-ci openshift-ci bot removed the lgtm label May 9, 2024
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unknown PR validation on existing cluster

Cluster Name: ikave-ibm2-416
Cluster Configuration:
PR Test Suite: tier4b
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job state: ABORTED.

@yitzhak12
Copy link
Contributor Author

In the PR validation above, I forgot to specify the test path.

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ikave-ibm2-416
Cluster Configuration:
PR Test Suite: tier4b
PR Test Path: tests/functional/z_cluster/cluster_expansion/test_resize_osd.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

@yitzhak12 yitzhak12 added the Verified Mark when PR was verified and log provided label May 9, 2024
Copy link

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ebenahar, prsurve, yitzhak12

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ebenahar ebenahar merged commit 86bb916 into red-hat-storage:master May 13, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/L PR that changes 100-499 lines Squad/Brown Test Case A test case PR Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants