Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating blockpool tests with capacity and usage verifications #9784

Merged
merged 12 commits into from
Jun 6, 2024
Merged

Updating blockpool tests with capacity and usage verifications #9784

merged 12 commits into from
Jun 6, 2024

Conversation

shivamdurgbuns
Copy link
Member

Re-opening old PR #6609

@shivamdurgbuns shivamdurgbuns requested review from a team as code owners May 9, 2024 12:46
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label May 9, 2024
ocs-ci
ocs-ci reviewed May 9, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: sdurgbun-test411
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/cross_functional/ui/test_create_pool_block_pool.py
Additional Test Params:
OCP VERSION: 4.11-ga
OCS VERSION: 4.11
tested against branch: master

Job PASSED.

ramkiperiy
ramkiperiy previously approved these changes May 9, 2024
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label May 9, 2024
@shivamdurgbuns shivamdurgbuns added the Verified Mark when PR was verified and log provided label May 9, 2024
ebondare
ebondare reviewed May 13, 2024
View reviewed changes
ocs_ci/ocs/ui/views.py Outdated Show resolved Hide resolved
@DanielOsypenko DanielOsypenko added the Squad/Black Covers UI specific test cases such as ODF Dashboard etc. label May 13, 2024
@DanielOsypenko DanielOsypenko requested a review from a team May 13, 2024 09:25
@DanielOsypenko
Copy link
Contributor

PR verification was done against OCP VERSION: 4.11-ga OCS VERSION: 4.11 and we want to merge to 4.16/master branch.
Please run the PR validation job against master branch, looks like you want to make the test pass on 4.12 and above, so you will need to merge to 4.16 first and cherry-pick to older versions.
The original bug was open against 4.9

DanielOsypenko
DanielOsypenko requested changes May 13, 2024
View reviewed changes
tests/cross_functional/ui/test_create_pool_block_pool.py Outdated Show resolved Hide resolved
ocs_ci/ocs/ui/block_pool.py Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm label May 13, 2024
ocs-ci
ocs-ci reviewed May 15, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: sdurgbun-odf416
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/cross_functional/ui/test_create_pool_block_pool.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

ebondare
ebondare reviewed May 15, 2024
View reviewed changes
ocs_ci/ocs/ui/views.py Outdated Show resolved Hide resolved
ocs-ci
ocs-ci reviewed May 16, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: sdurgbun-test416
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/cross_functional/ui/test_create_pool_block_pool.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job UNSTABLE (some or all tests failed).

@shivamdurgbuns
Copy link
Member Author

All the tests have passed here

@shivamdurgbuns
Copy link
Member Author

I have ran the test here and all have passed, could we please merge this pr
job: https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-deploy-ocs-cluster/38134/parameters/
test results: https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-deploy-ocs-cluster/38134/testReport/

@shivamdurgbuns
Updating blockpool tests with capacity and usage verifications
e236dc8 
Signed-off-by: Shivam Durgbuns <sdurgbun@redhat.com>
@shivamdurgbuns
Uncommenting the params
f99b860 
Signed-off-by: Shivam Durgbuns <sdurgbun@redhat.com>
@shivamdurgbuns
Function change
0cbfcea 
Signed-off-by: Shivam Durgbuns <sdurgbun@redhat.com>
@shivamdurgbuns
Removing exceptions and adding assertions
d6dbdf6 
Signed-off-by: Shivam Durgbuns <sdurgbun@redhat.com>
@shivamdurgbuns
Updating the function for calculating used capacity
804b2ac 
Signed-off-by: Shivam Durgbuns <sdurgbun@redhat.com>
@shivamdurgbuns
Uncommenting the tests
8f402b1 
Signed-off-by: Shivam Durgbuns <sdurgbun@redhat.com>
@shivamdurgbuns
Adding blockpool generic locator
6418daa 
Signed-off-by: Shivam Durgbuns <sdurgbun@redhat.com>
@shivamdurgbuns
Adding custom round function
c3e83e4 
Signed-off-by: Shivam Durgbuns <sdurgbun@redhat.com>
@shivamdurgbuns
Adding sanity check
b2d3965 
Signed-off-by: Shivam Durgbuns <sdurgbun@redhat.com>
@shivamdurgbuns
Removing sanity check
666beb9 
Signed-off-by: Shivam Durgbuns <sdurgbun@redhat.com>
@shivamdurgbuns
Resolving conflict
7eb3d7b 
Signed-off-by: Shivam Durgbuns <sdurgbun@redhat.com>
@shivamdurgbuns
Updating function call
028ab94 
Signed-off-by: Shivam Durgbuns <sdurgbun@redhat.com>
@shivamdurgbuns
Copy link
Member Author

Another verification job here: https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-deploy-ocs-cluster/38438/testReport/tests.cross_functional.ui.test_create_pool_block_pool/

@openshift-ci openshift-ci bot added the lgtm label Jun 6, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DanielOsypenko, ramkiperiy, shivamdurgbuns

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ramkiperiy ramkiperiy merged commit bfbfd99 into red-hat-storage:master Jun 6, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petr-balogh petr-balogh petr-balogh left review comments

@ebondare ebondare ebondare left review comments

@ocs-ci ocs-ci ocs-ci left review comments

@ramkiperiy ramkiperiy ramkiperiy approved these changes

@DanielOsypenko DanielOsypenko DanielOsypenko approved these changes

Assignees

@ramkiperiy ramkiperiy

@DanielOsypenko DanielOsypenko

Labels
lgtm size/L PR that changes 100-499 lines Squad/Black Covers UI specific test cases such as ODF Dashboard etc. Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@shivamdurgbuns @DanielOsypenko @petr-balogh @ramkiperiy @ebondare @ocs-ci @openshift-merge-robot