Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSS bz-2274193 noobaa db cleartext postgres password #9806

Merged
merged 8 commits into from
May 20, 2024

Conversation

OdedViner
Copy link
Contributor

@OdedViner OdedViner commented May 16, 2024

Signed-off-by: oviner <oviner@redhat.com>
@OdedViner OdedViner requested a review from a team as a code owner May 16, 2024 10:59
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label May 16, 2024
Signed-off-by: oviner <oviner@redhat.com>
Signed-off-by: oviner <oviner@redhat.com>
Signed-off-by: oviner <oviner@redhat.com>
@OdedViner
Copy link
Contributor Author

@hnallurv @PrasadDesala the test failed on ODF4.15.2 [as expected]

from ocs_ci.framework import config
from ocs_ci.ocs.resources import pod


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this test under MCG.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done



@tier2
@bugzilla("2274193")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont need this redundant bugzilla markers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Test Noobaa Security
"""

@green_squad
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move this test under mcg and add red_squad, mcg markers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@parikshithb parikshithb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, need to rectify other comments.

@PrasadDesala PrasadDesala added team/e2e E2E team related issues/PRs Customer defects Defects automated aspart of GSS closed loop labels May 17, 2024
Signed-off-by: oviner <oviner@redhat.com>
@OdedViner OdedViner requested a review from a team as a code owner May 17, 2024 13:41
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: oviner11-vsphere
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/functional/object/mcg/test_noobaa_db_cleartext_postgres_password.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

@sagihirshfeld
Copy link
Contributor

@OdedViner now that this is a Red Squad test you need to add the mcg decorator (in this case) for the PR checks to pass:

  INTERNALERROR> ocs_ci.ocs.exceptions.MissingDecoratorError: 
  INTERNALERROR> The following tests are missing either the @mcg or @rgw decorators: {
  INTERNALERROR>     "test_noobaa_db_cleartext_postgres_password": "/home/runner/work/ocs-ci/ocs-ci/tests/functional/object/mcg/test_noobaa_db_cleartext_postgres_password.py"
  INTERNALERROR> }
  INTERNALERROR> 
  INTERNALERROR> Red squad tests are required to be decorated with either mcg or rgw. Please add either depending on the tests's focus.

Signed-off-by: oviner <oviner@redhat.com>
@OdedViner
Copy link
Contributor Author

@OdedViner now that this is a Red Squad test you need to add the mcg decorator (in this case) for the PR checks to pass:

  INTERNALERROR> ocs_ci.ocs.exceptions.MissingDecoratorError: 
  INTERNALERROR> The following tests are missing either the @mcg or @rgw decorators: {
  INTERNALERROR>     "test_noobaa_db_cleartext_postgres_password": "/home/runner/work/ocs-ci/ocs-ci/tests/functional/object/mcg/test_noobaa_db_cleartext_postgres_password.py"
  INTERNALERROR> }
  INTERNALERROR> 
  INTERNALERROR> Red squad tests are required to be decorated with either mcg or rgw. Please add either depending on the tests's focus.

done

sagihirshfeld
sagihirshfeld previously approved these changes May 19, 2024
Signed-off-by: oviner <oviner@redhat.com>
Signed-off-by: oviner <oviner@redhat.com>
@openshift-ci openshift-ci bot added the lgtm label May 20, 2024
Copy link

openshift-ci bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: OdedViner, PrasadDesala, sagihirshfeld

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PrasadDesala PrasadDesala merged commit 38735ac into red-hat-storage:master May 20, 2024
5 of 6 checks passed
amr1ta pushed a commit to amr1ta/ocs-ci that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer defects Defects automated aspart of GSS closed loop lgtm size/M PR that changes 30-99 lines team/e2e E2E team related issues/PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants