Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Added onboarding token generation related functional tests for provider-client feature #9938

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

WIP: Added onboarding token generation related functional tests for provider-client feature #9938

wants to merge 25 commits into from

Conversation

amr1ta
Copy link
Contributor

@amr1ta amr1ta commented Jun 12, 2024

Added onboarding token generation related functional tests for provider-client feature

@amr1ta amr1ta requested review from a team as code owners June 12, 2024 14:11
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Jun 12, 2024
@amr1ta amr1ta force-pushed the onboarding-token-generation-ui branch 14 times, most recently from cc42719 to 9020bb9 Compare June 13, 2024 16:29
jilju
jilju previously approved these changes Jun 14, 2024
View reviewed changes
tests/functional/provider_client/test_onboarding_token_generation.py Outdated


@tier1
@green_squad
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a green squad test. May be yellow squad ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have updated in latest commit.

tests/functional/provider_client/test_onboarding_token_generation.py Outdated
@pytest.fixture(autouse=True)
def setup(self, request):
"""
Resetting the default value of KeyRotation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any code missing in this method for resetting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in latest commit.

tests/functional/provider_client/test_onboarding_token_generation.py Outdated
Comment on lines 54 to 186
Test to verify the respin of ux pod.
Steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Test to verify the respin of ux pod.
Steps:
Test to verify the respin of ux pod.
Steps:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in latest commit.

tests/functional/provider_client/test_onboarding_token_generation.py Outdated
timeout=180,
), "ux pod is not in running state as expected"

def test_respin_of_ux_server_pod(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a tier4c test. Please add marker in the test case level for all test cases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in latest commit.

tests/functional/provider_client/test_onboarding_token_generation.py Outdated
selector=constants.UX_BACKEND_SERVER_LABEL,
resource_count=1,
timeout=180,
), "ux pod is not in running state as expected"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
), "ux pod is not in running state as expected"
), "ux-backend-server pod is not in running state as expected"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in latest commit.

tests/functional/provider_client/test_onboarding_token_generation.py Outdated
"""
Test to verify the respin of ux pod.
Steps:
1. navigate to storage-->storage clients page
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention the step of deleting the ux-backend-server pod.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in latest commit.

tests/functional/provider_client/test_onboarding_token_generation.py Outdated

ux_pod_obj.delete()
log.info("wait some time for another ux-backend-server pod to come up")
time.sleep(30)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new pod will come up in 3-5 seconds. Please remove sleep for short period and use wait conditions for checking the new pod.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in latest commit.

tests/functional/provider_client/test_onboarding_token_generation.py Outdated
timeout=180,
), "ux pod is not in running state as expected"

def test_respin_of_ux_server_pod(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a separate test case to check the re-spin of pod is not needed. This will be part of tier4c pod re-spin tests. Please combine the test with test_onboarding_token_generation_option_is_available_in_ui(and change the name of test) to verify the impact of ux pod respin on token generation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have combined the test to check ux-backend-server pod is urunning and ux-backend-server pod respin testcases together.

@openshift-ci openshift-ci bot added the lgtm label Jun 14, 2024
@jilju jilju self-requested a review June 14, 2024 10:38
@jilju jilju removed their assignment Jun 14, 2024
fbalak
fbalak previously approved these changes Jun 14, 2024
View reviewed changes
@amr1ta amr1ta dismissed stale reviews from fbalak and jilju via 5d81873 June 14, 2024 14:41
@openshift-ci openshift-ci bot removed the lgtm label Jun 14, 2024
@ebondare
Copy link
Contributor

Could you please include a test run?

@amr1ta amr1ta force-pushed the onboarding-token-generation-ui branch from 5d81873 to 65e6515 Compare August 7, 2024 06:26
ebondare
ebondare previously approved these changes Aug 13, 2024
View reviewed changes
@amr1ta
Updated squad details
bede2dd 
Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
@amr1ta
Addressed review comments
a2f2cac 
Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
@amr1ta
Added a testcase for creating a hosted cluster and onboarding storage…
021a287 
…client from the hosted cluster

Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
@amr1ta
Updated with hci_provider_required fixture
16e8644 
Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
@amr1ta
Updated with create and destroy hypershift cluster fixtures
33d0b36 
Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
@amr1ta
Added steps to validate default storage-quota and create onboarding t…
acb877a 
…oken with limited storage quota

Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
@amr1ta
Corrected a typo
23a2576 
Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
@amr1ta
Corrected a typo
a4d1846 
Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
@amr1ta
removed duplicate import
0e63039 
Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
@amr1ta
Updated test
6cdad7f 
Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
@amr1ta
Updated test
c243c1f 
Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
@amr1ta
added sleep to let the dashboard load successfully and increaded the …
2b0d5f9 
…timeout for local-cluster load

Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
@amr1ta
added fixture for login and close browser
b9a9883 
Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
@amr1ta
Updated 'local-cluster_dropdown_item' locator to 'local-cluster_dropd…
88dd7ff 
…own' locator in navigate_to_local_cluster method

Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
@amr1ta
Updated few locators of generate onboarding token page
ddd6b7c 
Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
@amr1ta
updated navigate_to_all_clusters method
42f27a4 
Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
@amr1ta
Added ignore leftover tag
6bf355d 
Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
@amr1ta
Added retry in case of ResourceNotFoundError to collect_pod_container…
b9bb5f6 
…_rpm_package method

Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
@amr1ta
Imported locally to resolve circular import issue
6de6253 
Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
@amr1ta
Added parameter to accept storage_quota from config.env
8b6e710 
Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
@amr1ta
Updated onboardin token generation from ui
3f17617 
Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
@amr1ta amr1ta force-pushed the onboarding-token-generation-ui branch 3 times, most recently from 119ac5d to ea6ce94 Compare October 23, 2024 08:53
@amr1ta
Updated onboardin token generation from ui
ea98930 
Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
@amr1ta amr1ta force-pushed the onboarding-token-generation-ui branch 3 times, most recently from d581402 to 205ec51 Compare October 24, 2024 06:43
@amr1ta
Added setup method
a9ac0cb 
Signed-off-by: Amrita Mahapatra <49347640+amr1ta@users.noreply.github.com>
@amr1ta amr1ta force-pushed the onboarding-token-generation-ui branch from 205ec51 to a9ac0cb Compare October 24, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebondare ebondare ebondare left review comments

@DanielOsypenko DanielOsypenko DanielOsypenko left review comments

@fbalak fbalak fbalak left review comments

@jilju jilju Awaiting requested review from jilju

At least 2 approving reviews are required to merge this pull request.

Assignees

@fbalak fbalak

@ebondare ebondare

Labels
do-not-merge/work-in-progress size/L PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amr1ta @ebondare @fbalak @jilju @DanielOsypenko @openshift-merge-robot