Syncing latest changes from main for ocs-operator #2907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rewant Soni <resoni@redhat.com>
provider: update replicationID to be storageClass name
Signed-off-by: Rewant Soni <resoni@redhat.com>
provider: send vrcs with fixed replication schedule
This update ensures that the secret hash in the storage cluster status is updated only after all resources are created successfully. Previously, the status was updated prematurely, preventing the reconcile loop from re-running whether there was a failure or success. This change enables the reconcile process to continue retrying until all resources are successfully created. Signed-off-by: parth-gr <paarora@redhat.com>
external: Defer secret hash update until all resources are successfully created
Signed-off-by: Rewant Soni <resoni@redhat.com>
provider: generate vrcs name to align with internal mode
|
@rewantsoni Do we need your changes in 4.18? |
@iamniting yes we need them, they are a part of RDR for Provider Mode effort |
iamniting
approved these changes
Nov 25, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: df-build-team, iamniting The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from main branch