Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFBUGS-925: [release-4.18] controllers: add a new controller to setup mirroring #2908

Merged
merged 4 commits into from
Nov 26, 2024
Merged

DFBUGS-925: [release-4.18] controllers: add a new controller to setup mirroring #2908

merged 4 commits into from
Nov 26, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2878

/assign openshift-ci-robot

@rewantsoni
add rpc calls related to mirroring
3163ecc 
Signed-off-by: Rewant Soni <resoni@redhat.com>
@rewantsoni
add client side implementation
5395a7e 
Signed-off-by: Rewant Soni <resoni@redhat.com>

add generated changes

Signed-off-by: Rewant Soni <resoni@redhat.com>
@rewantsoni
add server side implementation
56688ba 
Signed-off-by: Rewant Soni <resoni@redhat.com>
@rewantsoni
controllers: add a new controller to setup mirroring
5e86f96 
Signed-off-by: Rewant Soni <resoni@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 26, 2024
Merged
@rewantsoni
Copy link
Member

rewantsoni commented Nov 26, 2024 •
edited by openshift-ci bot
Loading

/retitle DFBUGS-925: [release-4.18] controllers: add a new controller to setup mirroring

@openshift-ci openshift-ci bot changed the title [release-4.18] controllers: add a new controller to setup mirroring DFBUGS-925: [release-4.18] controllers: add a new controller to setup mirroring Nov 26, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Nov 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2024 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: This pull request references [Jira Issue DFBUGS-925](https://issues.redhat.com//browse/DFBUGS-925), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

This is an automated cherry-pick of #2878

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 676ea75 into red-hat-storage:release-4.18 Nov 26, 2024
11 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2024 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: [Jira Issue DFBUGS-925](https://issues.redhat.com//browse/DFBUGS-925): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-925](https://issues.redhat.com//browse/DFBUGS-925) has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #2878

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamniting iamniting iamniting approved these changes

Assignees

@iamniting iamniting

@openshift-ci-robot openshift-ci-robot

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-cherrypick-robot @rewantsoni @openshift-ci-robot @iamniting