Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an indentation issue in 'prometheus-ocs-rules.yaml' file #2921

Conversation

aruniiird
Copy link
Contributor

@aruniiird aruniiird commented Dec 5, 2024

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
@aruniiird aruniiird changed the title Fixed an indentation issue in 'prometheus-ocs-rules.yaml' file DFBUGS-951: Fixed an indentation issue in 'prometheus-ocs-rules.yaml' file Dec 5, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Dec 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 5, 2024

@aruniiird: This pull request references [Jira Issue DFBUGS-951](https://issues.redhat.com//browse/DFBUGS-951), which is invalid:

  • expected the bug to target the "odf-4.18" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@GowthamShanmugam
Copy link
Contributor

I can reproduce this issue on my 4.18 cluster, all ocs exporter realted alerting rules are missing.

@aruniiird
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 5, 2024

@aruniiird: This pull request references [Jira Issue DFBUGS-951](https://issues.redhat.com//browse/DFBUGS-951), which is invalid:

  • expected the bug to target the "odf-4.18" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aruniiird
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting and removed jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Dec 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 5, 2024

@aruniiird: This pull request references [Jira Issue DFBUGS-951](https://issues.redhat.com//browse/DFBUGS-951), which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (vkathole@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aruniiird
Copy link
Contributor Author

/cherry-pick release-4.18

@openshift-cherrypick-robot

@aruniiird: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aruniiird
Copy link
Contributor Author

@umangachapagain , @iamniting , can you please take a look? This is a test blocker (for one of the epic-happy-path) and QE cannot proceed without this.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2024
Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aruniiird, iamniting

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 6, 2024

@aruniiird: This pull request references [Jira Issue DFBUGS-951](https://issues.redhat.com//browse/DFBUGS-951), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (vkathole@redhat.com), skipping review request.

In response to this:

DFBUGS-951

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@iamniting iamniting changed the title DFBUGS-951: Fixed an indentation issue in 'prometheus-ocs-rules.yaml' file Fixed an indentation issue in 'prometheus-ocs-rules.yaml' file Dec 6, 2024
@openshift-ci-robot openshift-ci-robot removed jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Dec 6, 2024
@openshift-ci-robot
Copy link

@aruniiird: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

DFBUGS-951

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 61f6999 into red-hat-storage:main Dec 6, 2024
11 checks passed
@openshift-cherrypick-robot

@aruniiird: new pull request created: #2929

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants