Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filesystem: correct the pool name in the ux backend handler #2924

Merged
merged 1 commit into from
Dec 6, 2024
Merged

filesystem: correct the pool name in the ux backend handler #2924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/ux-backend/handlers/expandstorage/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ func createCephFilesystemStorageClass(w http.ResponseWriter, r *http.Request, cl
Parameters: map[string]string{
"clusterID": namespace,
"fsName": filesystemName,
"pool": poolName,
"pool": fmt.Sprintf("%s-%s", filesystemName, poolName),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is pool name mandatory when we expand the storage? if not Rook appends different value with integers

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaa in the UI the pool name is mandatory,
cc @SanjalKatiyar to keep me honest

Copy link
Member

@Madhu-1 Madhu-1 Dec 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in that case lets make it mandatory here(HTTP request) as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, UI has it as a mandatory field.

"csi.storage.k8s.io/provisioner-secret-name": "rook-csi-cephfs-provisioner",
"csi.storage.k8s.io/provisioner-secret-namespace": namespace,
"csi.storage.k8s.io/node-stage-secret-name": "rook-csi-cephfs-node",
Expand Down
Loading