RHDHPAI-160: merge ai-lab-helm-chart pipeline/task with rhdh-pipeline #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change and associated changes in the ai-lab-helm-charts and rhdh-pipeline repos, we allow for multiple forms of deployment update: - via argocd gitops, where the launching of rhdh-pipelines from via RHDH SW templates defined in this repo employ this form of deployment update - via k8s patch of the deployment instance, which our helm charts in ai-lab-helm-charts employ, and application repos are not managed through argocd
|
ah - missed the bit about https://docs.google.com/document/d/1hjZN6G-sDDkdSuXUZ12FkeaW5SoA64fgs1VejeOTfb4/edit?tab=t.0#heading=h.4wn8op67vyk9 will redo this PR by undoing / saving my original change, then run generate.sh and go from there |
|
so yeah the changes here are "for reference" ... I think I get it. Once redhat-ai-dev/rhdh-pipelines#9 merges I believe we run When I run it now, it effectively reverts my changes to what is in main branch in rhdh-pipelines |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
With this change and associated changes in the ai-lab-helm-charts and rhdh-pipeline repos, we allow for multiple forms of deployment update:
Which issue(s) this PR fixes:
https://issues.redhat.com/browse/RHDHPAI-160
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.
Tested in conjunction with redhat-ai-dev/rhdh-pipelines#9
How to test changes / Special notes to the reviewer:
A prior form of this PR's branch pointed to the branch associated with redhat-ai-dev/rhdh-pipelines#9 for the PAC pipeline and task refs.
I.e.
and
However, once redhat-ai-dev/rhdh-pipelines#9 merges, only the form needed in this PR that adds the additional tasks and binding of the gitops-auth workspace is needed.
We will want to merge this soon after or in conjunction with redhat-ai-dev/rhdh-pipelines#9 as there will be a disconnect between the pipelineruns and the build pipeline in the interim.