Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVHAS-549]remove clonepath after cdq is done #412

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

yangcao77
Copy link
Contributor

What does this PR do?:

This PR move the logic of removing clonepath to beginning of SendBackDetectionResult, ensure the clonepath is cleaned if execute with go module when CDQ is done, regardless of error or success case.

Which issue(s)/story(ies) does this PR fixes:

https://issues.redhat.com/browse/DEVHAS-549

PR acceptance criteria:

  • Unit/Functional tests

  • Documentation

  • Client Impact

How to test changes / Special notes to the reviewer:

Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: Stephanie <yangcao@redhat.com>
Copy link

openshift-ci bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maysunfaisal, yangcao77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [maysunfaisal,yangcao77]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 385 lines in your changes are missing coverage. Please review.

Comparison is base (5005e34) 83.98% compared to head (558c579) 78.01%.
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
- Coverage   83.98%   78.01%   -5.97%     
==========================================
  Files          31       35       +4     
  Lines        4259     4918     +659     
==========================================
+ Hits         3577     3837     +260     
- Misses        514      892     +378     
- Partials      168      189      +21     
Files Coverage Δ
contracts/application_pact_test_utils.go 0.00% <ø> (ø)
controllers/application_controller_finalizer.go 100.00% <100.00%> (ø)
controllers/component_controller_finalizer.go 68.00% <100.00%> (-1.24%) ⬇️
controllers/webhooks/application_webhook.go 100.00% <100.00%> (ø)
controllers/webhooks/component_webhook.go 100.00% <100.00%> (ø)
pkg/devfile/devfile.go 88.13% <100.00%> (-0.35%) ⬇️
pkg/util/util.go 94.30% <ø> (-1.33%) ⬇️
controllers/update.go 83.87% <85.71%> (-0.22%) ⬇️
controllers/application_controller.go 78.53% <75.00%> (-0.57%) ⬇️
cdq-analysis/pkg/detect.go 73.62% <81.81%> (-0.16%) ⬇️
... and 9 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yangcao77 yangcao77 merged commit 0818fb9 into redhat-appstudio:main Nov 9, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants