Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codecov ignore list - ignore token mock and contract test files #414

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

johnmcollier
Copy link
Member

Those files are test only, and shouldn't be included in coverage calculations

Those files are test only, and shouldn't be included in coverage calculations
Copy link

openshift-ci bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 275 lines in your changes are missing coverage. Please review.

Comparison is base (5005e34) 83.98% compared to head (761fea9) 81.07%.
Report is 23 commits behind head on main.

❗ Current head 761fea9 differs from pull request most recent head 53481d2. Consider uploading reports for the commit 53481d2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
- Coverage   83.98%   81.07%   -2.92%     
==========================================
  Files          31       33       +2     
  Lines        4259     4740     +481     
==========================================
+ Hits         3577     3843     +266     
- Misses        514      710     +196     
- Partials      168      187      +19     
Files Coverage Δ
controllers/application_controller_finalizer.go 100.00% <100.00%> (ø)
controllers/component_controller_finalizer.go 68.00% <100.00%> (-1.24%) ⬇️
controllers/webhooks/application_webhook.go 100.00% <100.00%> (ø)
controllers/webhooks/component_webhook.go 100.00% <100.00%> (ø)
pkg/devfile/devfile.go 88.13% <100.00%> (-0.35%) ⬇️
pkg/util/util.go 94.30% <ø> (-1.33%) ⬇️
controllers/update.go 83.87% <85.71%> (-0.22%) ⬇️
controllers/application_controller.go 80.00% <75.00%> (+0.89%) ⬆️
cdq-analysis/pkg/detect.go 73.62% <81.81%> (-0.16%) ⬇️
cdq-analysis/pkg/util.go 93.29% <76.92%> (-4.80%) ⬇️
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

codecov.yml Outdated Show resolved Hide resolved
@johnmcollier johnmcollier changed the title Ignore contract test files in Codecov Update codecov ignore list - ignore token mock and contract test files Nov 14, 2023
@flacatus
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 14, 2023
@johnmcollier johnmcollier merged commit b31090d into main Nov 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants