Fix deployment spec when replica set to 0

[kim-tsao]

What does this PR do?:

Removes the if statement that was used to set the replica field in the deployment spec since it should always be set to a value. If field is unset, it should have a default value of 0.

Which issue(s)/story(ies) does this PR fixes:

https://issues.redhat.com/browse/RHTAPBUGS-12

PR acceptance criteria:

• [X ] Unit/Functional tests

Updated the unit tests to include the expected component attributes values for deployment/replicas

• Documentation

• Client Impact

How to test changes / Special notes to the reviewer:

Manually tested:

1. Built the HAS image and deployed on a local cluster. Created a token with read and write permissions to write into a test org
2. Deployed the sample Application and Component. Verified the replica was set to 1 in the generated deployment
3. Updated the Component CR to set replicas to 0. Verified the replica was set to 0 in the generated deployment
4. Updated the Component CR to remove the replica field. This did not trigger an update since existing deployment was equivalent. Internally, the deployed CR instance had the replica field removed but the deployment/replicas: 0 attribute remained

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46ad293) 81.34% compared to head (9bdc923) 81.34%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
- Coverage   81.34%   81.34%   -0.01%     
==========================================
  Files          32       32              
  Lines        4788     4787       -1     
==========================================
- Hits         3895     3894       -1     
  Misses        702      702              
  Partials      191      191              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, kim-tsao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [johnmcollier,kim-tsao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

New changes are detected. LGTM label has been removed.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information