[DEVHAS-546] Manage build-nudges fields when Component is deleted #428
Conversation
Signed-off-by: John Collier <jcollier@redhat.com>
Signed-off-by: John Collier <jcollier@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
==========================================
+ Coverage 81.34% 81.37% +0.03%
==========================================
Files 32 32
Lines 4787 4886 +99
==========================================
+ Hits 3894 3976 +82
- Misses 702 713 +11
- Partials 191 197 +6 ☔ View full report in Codecov by Sentry. |
| if err != nil { | ||
| // Don't block component deletion if this fails, but log and continue | ||
| componentlog.Error(err, "error deleting component name from build-nudges-ref") | ||
| continue |
There was a problem hiding this comment.
already end of loop, do not need this continue
| if err != nil { | ||
| // Don't block component deletion if this fails, but log and continue | ||
| componentlog.Error(err, "error deleting component name from build-nudges-ref") | ||
| continue |
There was a problem hiding this comment.
already end of loop, do not need this continue
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnmcollier, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: John Collier <jcollier@redhat.com>
|
New changes are detected. LGTM label has been removed. |
|
Kudos, SonarCloud Quality Gate passed!
|
What does this PR do?:
ValidateDeletewebhook function to handle scenarios when a Component is deleted:spec.buildNudgesRef, it should remove the component's name from the nudged component's statusspec.buildNudgesReffieldWhich issue(s)/story(ies) does this PR fixes:
https://issues.redhat.com/browse/DEVHAS-546
PR acceptance criteria:
Unit/Functional tests
Documentation
Client Impact
How to test changes / Special notes to the reviewer: