Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVHAS-553] Add SPI FCR test checks for Component controller #429

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

maysunfaisal
Copy link
Member

@maysunfaisal maysunfaisal commented Dec 7, 2023

What does this PR do?:

Adds in a couple of SPI FCR tests for the Component controller:

  • Ensure SPI FCR has an owner reference tied to its associated Component
    • Cant test SPI FCR deletion because the Kube client created from a test config env does not process owner ref deletions
  • Ensure SPI FCR is persisted even if its associated Component is in an error state

Which issue(s)/story(ies) does this PR fixes:

https://issues.redhat.com/browse/DEVHAS-553

PR acceptance criteria:

  • Unit/Functional tests

  • Documentation

  • Client Impact

How to test changes / Special notes to the reviewer:

Tests should pass

Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.9% 1.9% Duplication

@maysunfaisal maysunfaisal changed the title Add SPI FCR test checks for Component controller [DEVHAS-553] Add SPI FCR test checks for Component controller Dec 7, 2023
Copy link

openshift-ci bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, maysunfaisal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johnmcollier,maysunfaisal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maysunfaisal maysunfaisal merged commit db849d5 into redhat-appstudio:main Dec 7, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants