Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error log format #432

Merged

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Jan 2, 2024

What does this PR do?:

Simple fix for the error log of the gitops repo update failure. The code didn't include the fmt.Sprintf() function and as a result inside the log we would only see the %v variables as they are and not their content. After adding fmt.Sprintf() this is fixed.

Which issue(s)/story(ies) does this PR fixes:

fixes https://issues.redhat.com/browse/RHTAPBUGS-1016

PR acceptance criteria:

  • Unit/Functional tests

  • Documentation

  • Client Impact

How to test changes / Special notes to the reviewer:

Signed-off-by: thepetk <thepetk@gmail.com>
Copy link

sonarqubecloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

openshift-ci bot commented Jan 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maysunfaisal, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [maysunfaisal,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk
Copy link
Contributor Author

thepetk commented Jan 3, 2024

/retest

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 73 lines in your changes are missing coverage. Please review.

Comparison is base (2fc5811) 81.39% compared to head (29bbb9f) 80.68%.
Report is 1 commits behind head on main.

Files Patch % Lines
controllers/component_controller.go 47.36% 45 Missing and 5 partials ⚠️
pkg/devfile/devfile.go 41.17% 10 Missing ⚠️
pkg/devfile/errors.go 0.00% 6 Missing ⚠️
controllers/update.go 16.66% 5 Missing ⚠️
controllers/errors.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
- Coverage   81.39%   80.68%   -0.72%     
==========================================
  Files          32       32              
  Lines        4907     4995      +88     
==========================================
+ Hits         3994     4030      +36     
- Misses        715      763      +48     
- Partials      198      202       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thepetk thepetk merged commit 30821d6 into redhat-appstudio:main Jan 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants