Enable cross-Application nudging #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to enable improved organization of Components and Applications, we want to loosen the requirement that all nudging happens within the same Application. Therefore we no longer need to run webhook validation to adhere to this constraint. Resolves: issues.redhat.com/browse/DEVHAS-593 Signed-off-by: arewm <arewm@users.noreply.github.com>
arewm
force-pushed
the
loosen-app-nudge-restriction
branch
from
bdaccc0 to
63ea49e
Compare
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arewm, johnmcollier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test application-service-e2e |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #434 +/- ##
==========================================
- Coverage 80.56% 80.49% -0.08%
==========================================
Files 32 32
Lines 5016 5013 -3
==========================================
- Hits 4041 4035 -6
- Misses 770 772 +2
- Partials 205 206 +1 ☔ View full report in Codecov by Sentry. |
arewm
added a commit
to arewm/build-service
that referenced
this pull request
Jan 18, 2024
I removed the restriction that nudging can only happen between Components in the same application in HAS with redhat-appstudio/application-service#434 This change removes that restriction from the build service as well. Signed-off-by: arewm <arewm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
In order to enable improved organization of Components and Applications, we want to loosen the requirement that all nudging happens within the same Application. Therefore we no longer need to run webhook validation to adhere to this constraint.
Which issue(s)/story(ies) does this PR fixes:
issues.redhat.com/browse/DEVHAS-593
PR acceptance criteria:
Unit/Functional tests
Documentation
Client Impact
How to test changes / Special notes to the reviewer: