[DEVHAS-611] Update Component create metrics for better data

[maysunfaisal]

What does this PR do?:

• Updates the component metrics only if the current state is different than the prev state, this helps avoid spamming metrics due to HAS controller retry logic
• Wrapper function for Component create metrics (other metrics left untouched, outside the scope of PR), whose job is to compare previous error and current error and update metrics accordingly
• Remove metrics tracking from Gitops logic due to future commitments
• Rearrange metrics dir to individual files (cut-paste)

Which issue(s)/story(ies) does this PR fixes:

https://issues.redhat.com/browse/DEVHAS-611

PR acceptance criteria:

• Unit/Functional tests

• Documentation

• Client Impact

How to test changes / Special notes to the reviewer:

tests should pass

[michael-valdron]

/retest

[michael-valdron]

Changes looks good to me.

I saw e2e tests did not fail under a recent PR, #442, seeing if retest does not reproduce error: the path "deploy/member-operator/appstudio-dev/" does not exist.

[michael-valdron]

@maysunfaisal Rebasing on your recent changes might fix https://github.com/redhat-appstudio/application-service/actions/runs/7791255552/job/21327116796?pr=441, but I also noticed your comment about the linter fix: #442 (comment)

[michael-valdron]

/retest

Failures this time look like flaky ones, retrying.

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
1.9% Duplication on New Code

See analysis details on SonarCloud

[maysunfaisal]

@michael-valdron This PR can be lgtm'd.

I confirmed that the tekton pipeline we are looking for a success is application-service-on-pull-request which is passing, the pipeline has-on-pull-request is outdated and there is a PR to remove it #438.

The outdated tekton builds are now replaced by konflux builds and the application-service-on-pull-request pipeline runs on Konflux:

(Confirmed on older PRs and my direct conversation with John)

[michael-valdron]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maysunfaisal, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [maysunfaisal,michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment