-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container port to manager container (addresses kube-linter error) #442
Add container port to manager container (addresses kube-linter error) #442
Conversation
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
==========================================
+ Coverage 80.43% 80.49% +0.05%
==========================================
Files 32 32
Lines 5013 5013
==========================================
+ Hits 4032 4035 +3
+ Misses 774 772 -2
+ Partials 207 206 -1 ☔ View full report in Codecov by Sentry. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maysunfaisal, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The tekton pipleline for infra deploy update has been removed so it wont pass for now.. Manual updates are required. |
What does this PR do?:
Adds in the container port to the manager container because the kube linter from stackrox was complaining about it:
Which issue(s)/story(ies) does this PR fixes:
N/A
PR acceptance criteria:
Unit/Functional tests
Documentation
Client Impact
How to test changes / Special notes to the reviewer: