Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container port to manager container (addresses kube-linter error) #442

Merged

Conversation

maysunfaisal
Copy link
Member

@maysunfaisal maysunfaisal commented Feb 6, 2024

What does this PR do?:

Adds in the container port to the manager container because the kube linter from stackrox was complaining about it:

Error: found 2 lint errors
/home/runner/work/application-service/application-service/.kube-linter/manifests.yaml: (object: application-service-system/application-service-controller-manager apps/v1, Kind=Deployment) container "manager" does not expose port 8081 for the HTTPGet (check: liveness-port, remediation: Check which ports you've exposed and ensure they match what you have specified in the liveness probe.)

/home/runner/work/application-service/application-service/.kube-linter/manifests.yaml: (object: application-service-system/application-service-controller-manager apps/v1, Kind=Deployment) container "manager" does not expose port 8081 for the HTTPGet (check: readiness-port, remediation: Check which ports you've exposed and ensure they match what you have specified in the readiness probe.)

Which issue(s)/story(ies) does this PR fixes:

N/A

PR acceptance criteria:

  • Unit/Functional tests

  • Documentation

  • Client Impact

How to test changes / Special notes to the reviewer:

  • tests should pass
  • manually deployed HAS on my cluster and created application,components to confirm HAS pod runs fine
$ oc get po -n application-service-system
NAME                                                      READY   STATUS    RESTARTS   AGE
application-service-controller-manager-78f45864f7-p277v   2/2     Running   0          11m

Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
@openshift-ci openshift-ci bot requested review from elsony and kim-tsao February 6, 2024 22:54
@openshift-ci openshift-ci bot added the approved label Feb 6, 2024
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
1.9% Duplication on New Code

See analysis details on SonarCloud

@maysunfaisal maysunfaisal changed the title Add container port to manager container Add container port to manager container (addresses kube-linter error) Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c8dade7) 80.43% compared to head (4142901) 80.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
+ Coverage   80.43%   80.49%   +0.05%     
==========================================
  Files          32       32              
  Lines        5013     5013              
==========================================
+ Hits         4032     4035       +3     
+ Misses        774      772       -2     
+ Partials      207      206       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thepetk
Copy link
Contributor

thepetk commented Feb 7, 2024

/retest

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maysunfaisal, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [maysunfaisal,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maysunfaisal maysunfaisal merged commit 632e05e into redhat-appstudio:main Feb 7, 2024
16 of 17 checks passed
@maysunfaisal
Copy link
Member Author

The tekton pipleline for infra deploy update has been removed so it wont pass for now.. Manual updates are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants