Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KFLUXBUGS-1105]: Retrieve Component before updating status for build-nudged-by #444

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

johnmcollier
Copy link
Member

What does this PR do?:

This PR ensures that we retrieve the most recent version of the Component before updating its status.build-nudged-by field. The should prevent an issue where the nudging component isn't referenced in that field.

Which issue(s)/story(ies) does this PR fixes:

https://issues.redhat.com/projects/KFLUXBUGS/issues/KFLUXBUGS-1105

PR acceptance criteria:

  • Unit/Functional tests

  • Documentation

  • Client Impact

How to test changes / Special notes to the reviewer:

Signed-off-by: John Collier <jcollier@redhat.com>
@openshift-ci openshift-ci bot requested review from elsony and kim-tsao February 13, 2024 18:47
Signed-off-by: John Collier <jcollier@redhat.com>
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
2.2% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johnmcollier,michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (3041882) 80.66% compared to head (7f15d5c) 80.57%.

Files Patch % Lines
controllers/webhooks/component_webhook.go 45.45% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
- Coverage   80.66%   80.57%   -0.10%     
==========================================
  Files          35       35              
  Lines        5033     5040       +7     
==========================================
+ Hits         4060     4061       +1     
- Misses        770      774       +4     
- Partials      203      205       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnmcollier johnmcollier merged commit 4863efd into redhat-appstudio:main Feb 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants