Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Devtools Week] Rename RHTAP occurrences to Konflux #449

Conversation

michael-valdron
Copy link
Contributor

What does this PR do?:

Changes occurrences of RHTAP to current name Konflux in source and documentation.

Which issue(s)/story(ies) does this PR fixes:

PR acceptance criteria:

  • Unit/Functional tests

  • Documentation

  • Client Impact

How to test changes / Special notes to the reviewer:

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Copy link

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron changed the title Rename RHTAP occurrences to Konflux [DevTools Week] Rename RHTAP occurrences to Konflux Feb 29, 2024
@michael-valdron michael-valdron changed the title [DevTools Week] Rename RHTAP occurrences to Konflux [Devtools Week] Rename RHTAP occurrences to Konflux Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.63%. Comparing base (ea473f6) to head (5c7694b).

❗ Current head 5c7694b differs from pull request most recent head 7e167bb. Consider uploading reports for the commit 7e167bb to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #449   +/-   ##
=======================================
  Coverage   80.63%   80.63%           
=======================================
  Files          35       35           
  Lines        5040     5040           
=======================================
  Hits         4064     4064           
  Misses        772      772           
  Partials      204      204           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-valdron Looks good to me. A quick question is if you think is ok to update these dockerfile labels:

  • description
  • io.k8s.description
  • summary

@michael-valdron
Copy link
Contributor Author

@michael-valdron Looks good to me. A quick question is if you think is ok to update these dockerfile labels:

* `description`

* `io.k8s.description`

* `summary`

@thepetk Oops good catch I'll revise these as well.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@maysunfaisal
Copy link
Member

@michael-valdron I would check what the other teams Dockerfile labels look like if they have one

Copy link

openshift-ci bot commented Mar 1, 2024

@michael-valdron: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/application-service-e2e 7e167bb link true /test application-service-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@michael-valdron
Copy link
Contributor Author

@michael-valdron I would check what the other teams Dockerfile labels look like if they have one

From what I can see we are the first to undergo the renaming to Konflux, to this extent a least. Other components still use RHTAP in their labels. The label I am most concerned with keeping consistent with other teams is io.openshift.tags to keep HAS grouped with other components.

Some that I found still use the rhtap tag for their images:

Others don't specify any tags:

@maysunfaisal Based on these findings should we just revert io.openshift.tags to rhtap and keep the renaming in the descriptor fields? Or maybe we exclude our Dockerfile from these changes at the time?

@maysunfaisal
Copy link
Member

@michael-valdron lets bring this up in the standup tomorrow. I dont think it should matter.

@michael-valdron
Copy link
Contributor Author

@maysunfaisal Based on these findings should we just revert io.openshift.tags to rhtap and keep the renaming in the descriptor fields? Or maybe we exclude our Dockerfile from these changes at the time?

During team discussion on this, we decided to revert back to rhtap for all Dockerfile labels to avoid bundling and metric issues.

@michael-valdron michael-valdron deleted the chore/rhtap-to-konflux branch May 2, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants