-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Devtools Week] Rename RHTAP occurrences to Konflux #449
[Devtools Week] Rename RHTAP occurrences to Konflux #449
Conversation
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #449 +/- ##
=======================================
Coverage 80.63% 80.63%
=======================================
Files 35 35
Lines 5040 5040
=======================================
Hits 4064 4064
Misses 772 772
Partials 204 204 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michael-valdron Looks good to me. A quick question is if you think is ok to update these dockerfile labels:
description
io.k8s.description
summary
@thepetk Oops good catch I'll revise these as well. |
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Quality Gate passedIssues Measures |
@michael-valdron I would check what the other teams Dockerfile labels look like if they have one |
@michael-valdron: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
From what I can see we are the first to undergo the renaming to Konflux, to this extent a least. Other components still use RHTAP in their labels. The label I am most concerned with keeping consistent with other teams is Some that I found still use the Others don't specify any tags: @maysunfaisal Based on these findings should we just revert |
@michael-valdron lets bring this up in the standup tomorrow. I dont think it should matter. |
During team discussion on this, we decided to revert back to |
What does this PR do?:
Changes occurrences of RHTAP to current name Konflux in source and documentation.
Which issue(s)/story(ies) does this PR fixes:
PR acceptance criteria:
Unit/Functional tests
Documentation
Client Impact
How to test changes / Special notes to the reviewer: