Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-git in CDQ package #452

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

johnmcollier
Copy link
Member

Bumps go-git to v5.11

Signed-off-by: John Collier <jcollier@redhat.com>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.2% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johnmcollier,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be able to bump github.com/devfile/library/v2 to a later revision to have the github.com/go-git/go-git/v5 indirect dependency bump to v5.11.0 without needing replace.

@michael-valdron
Copy link
Contributor

Should be able to bump github.com/devfile/library/v2 to a later revision to have the github.com/go-git/go-git/v5 indirect dependency bump to v5.11.0 without needing replace.

We can also bump to github.com/devfile/library/v2 v2.2.2 later once the release is cut. For now, I think keeping it a revision for the security patch is fine.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.63%. Comparing base (ea473f6) to head (a334e65).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #452   +/-   ##
=======================================
  Coverage   80.63%   80.63%           
=======================================
  Files          35       35           
  Lines        5040     5040           
=======================================
  Hits         4064     4064           
  Misses        772      772           
  Partials      204      204           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnmcollier johnmcollier merged commit e1c0a65 into redhat-appstudio:main Mar 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants