-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go-git in CDQ package #452
Update go-git in CDQ package #452
Conversation
Signed-off-by: John Collier <jcollier@redhat.com>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnmcollier, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be able to bump github.com/devfile/library/v2
to a later revision to have the github.com/go-git/go-git/v5
indirect dependency bump to v5.11.0
without needing replace
.
We can also bump to |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #452 +/- ##
=======================================
Coverage 80.63% 80.63%
=======================================
Files 35 35
Lines 5040 5040
=======================================
Hits 4064 4064
Misses 772 772
Partials 204 204 ☔ View full report in Codecov by Sentry. |
Bumps go-git to v5.11